Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Assembler - Fast preview component max-height: 2000px cuts off patterns in tablet viewport #72313

Closed
3 tasks done
miksansegundo opened this issue Jan 19, 2023 · 0 comments
Assignees

Comments

@miksansegundo
Copy link
Contributor

miksansegundo commented Jan 19, 2023

Description

The fast preview component used for the large preview in the assembler has a max-height: 2000px per pattern, which is not tall enough for some section patterns, and they are being cut off.

Image

Testing steps

  • Create a new site, choose a domain, and a plan...
  • Click continue until the Design picker, and scroll down to click Start designing
  • Add the pattern with four images in a grid 2x2
    Image
  • Check the large preview using the tablet viewport
    Image

Acceptance criteria

  • Patterns should not be cut off in the large preview
Before After
Image Image

Dev tasks

  • The component PatternRenderer should have the option to use or not the max-height: 2000px. See the line here.
  • The component PatternRenderer in PatternLargePreview should not use max-height. See the line here.

Related

#72253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant