From 9f5f2257ab8d516eb332f83e8327089c4f9897fd Mon Sep 17 00:00:00 2001
From: Keenan Brock <keenan@thebrocks.net>
Date: Tue, 1 Oct 2024 13:09:09 -0400
Subject: [PATCH 1/2] upgrade Factorybot to ruby3.3 friendly version

---
 Gemfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Gemfile b/Gemfile
index 357d44f5966..296ed9bdf81 100644
--- a/Gemfile
+++ b/Gemfile
@@ -309,7 +309,7 @@ group :test do
   gem "bundler-audit",                                       :require => false
   gem "capybara",                       "~>2.5.0",           :require => false
   gem "db-query-matchers",              "~>0.11.0"
-  gem "factory_bot",                    "~>5.1",             :require => false
+  gem "factory_bot",                    "~>6.5",             :require => false
   gem "simplecov",                      ">=0.21.2",          :require => false
   gem "timecop",                        "~>0.9", "!= 0.9.7", :require => false
   gem "vcr",                            "~>6.1",             :require => false

From a4ea62f389d12180f39177e134e04dcad7758597 Mon Sep 17 00:00:00 2001
From: Keenan Brock <keenan@thebrocks.net>
Date: Wed, 16 Oct 2024 18:20:05 -0400
Subject: [PATCH 2/2] Remove invalid factories

Related to https://github.com/ManageIQ/manageiq-providers-workflows/pull/118

These factories were added: https://github.com/ManageIQ/manageiq/pull/22316
But were removed: https://github.com/ManageIQ/manageiq/pull/22503

They were basically NO-OP factories, so removing is no big deal

For some reason, older versions of FactoryBot were ok with a bad reference (probably because the klass was overridden anyway)
But newer versions of FactoryBot complained
---
 spec/factories/workflow.rb          | 3 ---
 spec/factories/workflow_instance.rb | 5 -----
 2 files changed, 8 deletions(-)
 delete mode 100644 spec/factories/workflow.rb
 delete mode 100644 spec/factories/workflow_instance.rb

diff --git a/spec/factories/workflow.rb b/spec/factories/workflow.rb
deleted file mode 100644
index 1538bb4d08f..00000000000
--- a/spec/factories/workflow.rb
+++ /dev/null
@@ -1,3 +0,0 @@
-FactoryBot.define do
-  factory :workflow
-end
diff --git a/spec/factories/workflow_instance.rb b/spec/factories/workflow_instance.rb
deleted file mode 100644
index 64a2e82e8c2..00000000000
--- a/spec/factories/workflow_instance.rb
+++ /dev/null
@@ -1,5 +0,0 @@
-FactoryBot.define do
-  factory :workflow_instance do
-    status { "pending" }
-  end
-end