Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] New placeholder name doesn't display name #21

Open
adelando opened this issue May 12, 2022 · 4 comments
Open

[BUG] New placeholder name doesn't display name #21

adelando opened this issue May 12, 2022 · 4 comments

Comments

@adelando
Copy link

adelando commented May 12, 2022

Hello,

With the new placeholder %boosters_< name >_name% it does not display any title but seconds and other placeholders do.

for example, this is my config using TAB for bossbars...

booster_bonushealththree:
style: "PROGRESS"
color: "YELLOW"
progress: "100"
text: "#e7a9f5 #5ae0c8Active: #e7a9f5 %boosters_bonushealththree_name% &5&l| #5ae0c8Timer: #e7a9f5 %boosters_bonushealththree_seconds_remaining%"
display-condition: '%boosters_bonushealththree_seconds_remaining%>1'

"bonushealththree" being my booster ID

And this is how it displays.
2022-05-12_16 01 11

@adelando adelando changed the title [BUG] New placeholder doesn't display name [BUG] New placeholder name doesn't display name May 12, 2022
@WillFP
Copy link
Member

WillFP commented May 12, 2022

I can't recreate that - it definitely works for me

@adelando
Copy link
Author

I’ve seen this not working for a few people in the boosters discord channel, all other new placeholders seem to work fine just the name placeholder. I’ve also tried shortening the id name and still the same.

@natereprogle
Copy link
Contributor

Yeah, same for me. All the placeholders except the name placeholder work. Is there not a way to implement a placeholder to display any active booster, like a wildcard? That'd be really nice

@natereprogle
Copy link
Contributor

natereprogle commented Jun 8, 2022

Actually, pretty sure I see what's going on. There isn't a name placeholder being registered by this plugin.
https://github.com/Auxilor/Boosters/blob/master/eco-core/core-plugin/src/main/kotlin/com/willfp/boosters/boosters/Booster.kt

@WillFP I created a pull request, but I'm not familiar with Kotlin, so hopefully this is the correct syntax
#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants