Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should there be a queryFeeDetails RPC endpoint established for automationPrice? #447

Closed
chrisli30 opened this issue Oct 8, 2023 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@chrisli30
Copy link
Member

In automationTime, there’s a specific RPC interface for querying fees. Although fee logic in automationPrice is simple at the moment, I think we still need an interface to return the actual fee deducted for schedule + execution. Please check the code of query_fee_details of automationTime to see if a similar interface is required for automationPrice

For example, this is the interface for developers, auto-generated by the chain’s RPC metadata.
https://github.com/OAK-Foundation/oak.js/blob/22ae77e28aa40b9f69158cc750a2c5841dc34d4c/packages/types/src/automationTime.ts#L26C4-L32C7

@chrisli30 chrisli30 added the question Further information is requested label Oct 8, 2023
@v9n
Copy link
Member

v9n commented Oct 13, 2023

Yes, this make sense.

@v9n v9n closed this as completed in 72fda9f Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants