Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Keys-Enum #10889

Open
timunie opened this issue Apr 3, 2023 · 2 comments
Open

Improve Keys-Enum #10889

timunie opened this issue Apr 3, 2023 · 2 comments

Comments

@timunie
Copy link
Contributor

timunie commented Apr 3, 2023

These keys seems to be also used for the MacOS command key ()

/// <summary>
/// The left Windows key.
/// </summary>
LWin = 70,
/// <summary>
/// The right Windows key.
/// </summary>
RWin = 71,
.

IMO we should either:

  • Rename the key (which is a breaking change)
  • (or) improve the XML-comment to reflect this.

Related:
#10690 (reply in thread)

Anyone owning a Mac, can you confirm this?

@Mrxx99
Copy link
Contributor

Mrxx99 commented Apr 3, 2023

It should also be possible to add an enum alias, aka a new member with different name and same value, that is often used for such purposes, the XML docs would tell it is the same as the other

@Mbucari
Copy link

Mbucari commented Apr 5, 2023

Anyone owning a Mac, can you confirm this?

Well, I can. I have a mac mini with an off-brand mac keyboard. The left command key is LWin, and the right command key is RWin.

EDIT*

And yes, you can have multiple enum names with the same value. aliasing is the right approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants