Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it a requirement to have SwiftLint setup locally #58

Closed
AvdLee opened this issue Dec 30, 2019 · 6 comments · Fixed by #73
Closed

Make it a requirement to have SwiftLint setup locally #58

AvdLee opened this issue Dec 30, 2019 · 6 comments · Fixed by #73
Assignees
@AvdLee
Labels
enhancement New feature or request

Comments

@AvdLee
Copy link
Owner

AvdLee commented Dec 30, 2019

Ideally, the project should fail to build if SwiftLint is not installed. This is to make sure that CI and local environment are triggering the same warnings.
@AvdLee AvdLee added the enhancement New feature or request label Dec 30, 2019
@AvdLee AvdLee self-assigned this Dec 30, 2019
@ruipfcosta
Copy link
Collaborator

Hey @AvdLee, I'm curious about what options are available in order to integrate SwiftLint. What approach are you thinking, creating an Xcode project and using a build phase?

@AvdLee
Copy link
Owner Author

AvdLee commented Jan 3, 2020

creating an Xcode project and using a build phase?

Exactly! The example project is already using SwiftLint but it's not failing if SwiftLint is not installed. We should change that to make sure that the coding guidelines are respected.

@ruipfcosta
Copy link
Collaborator

That's interesting, because by creating an Xcode project file we should also be able to tackle this issue related to Carthage support 😅

@github-actions
Copy link

github-actions bot commented Feb 7, 2020

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Feb 7, 2020
@AvdLee
Copy link
Owner Author

AvdLee commented Feb 7, 2020

This will be fixed with the WeTransfer-iOS-CI update we're working on!

@AvdLee AvdLee removed the Stale label Feb 7, 2020
@AvdLee AvdLee mentioned this issue Mar 8, 2020
Merged
6 tasks
@AvdLee AvdLee closed this as completed in #73 Mar 8, 2020
@SwiftLeeBot
Copy link
Collaborator

The pull request #73 that closed this issue was merged and released as part of Release 1.0.0 🚀
Please let us know if the functionality works as expected as a reply here. If it does not, please open a new issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AvdLee AvdLee

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CI and implement GitBuddy AvdLee/appstoreconnect-swift-sdk
3 participants
@ruipfcosta @AvdLee @SwiftLeeBot