From 32db7521eb788ff38f4352192d695c90a5ff6592 Mon Sep 17 00:00:00 2001 From: Guillaume Chervet Date: Sat, 29 Jun 2024 20:45:11 +0200 Subject: [PATCH 1/9] fix(slimfaas): scale down add log --- src/SlimFaas/ReplicasService.cs | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/SlimFaas/ReplicasService.cs b/src/SlimFaas/ReplicasService.cs index 8ce4562e..5982d317 100644 --- a/src/SlimFaas/ReplicasService.cs +++ b/src/SlimFaas/ReplicasService.cs @@ -126,9 +126,18 @@ public async Task CheckScaleAsync(string kubeNamespace) tickLastCall = ticksLastCall[information.Deployment]; } + bool timeElapsedWithoutRequest = TimeSpan.FromTicks(tickLastCall) + - TimeSpan.FromSeconds(GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)) < - TimeSpan.FromTicks(DateTime.UtcNow.Ticks); + TimeSpan.FromSeconds(GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)) < TimeSpan.FromTicks(DateTime.UtcNow.Ticks) + + if (logger.IsEnabled(LogLevel.Information)) + { + var time = TimeSpan.FromTicks(tickLastCall) + + TimeSpan.FromSeconds( + GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)) - + TimeSpan.FromTicks(DateTime.UtcNow.Ticks); + logger.LogInformation("Time elapsed without request for {Deployment} is {TimeElapsedWithoutRequest}s", deploymentInformation.Deployment, time.Seconds); + } int currentScale = deploymentInformation.Replicas; if (timeElapsedWithoutRequest) { From b64f5bf2793ffb07dffae03661ddab6211b0c8f0 Mon Sep 17 00:00:00 2001 From: Guillaume Chervet Date: Sat, 29 Jun 2024 21:55:57 +0200 Subject: [PATCH 2/9] update --- src/SlimFaas/ReplicasService.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SlimFaas/ReplicasService.cs b/src/SlimFaas/ReplicasService.cs index 5982d317..6850b2d3 100644 --- a/src/SlimFaas/ReplicasService.cs +++ b/src/SlimFaas/ReplicasService.cs @@ -128,7 +128,7 @@ public async Task CheckScaleAsync(string kubeNamespace) bool timeElapsedWithoutRequest = TimeSpan.FromTicks(tickLastCall) + - TimeSpan.FromSeconds(GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)) < TimeSpan.FromTicks(DateTime.UtcNow.Ticks) + TimeSpan.FromSeconds(GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)) < TimeSpan.FromTicks(DateTime.UtcNow.Ticks); if (logger.IsEnabled(LogLevel.Information)) { From 8af439ac0898f9229f5cc30a415b218f0b846a79 Mon Sep 17 00:00:00 2001 From: Guillaume Chervet Date: Sat, 29 Jun 2024 21:56:29 +0200 Subject: [PATCH 3/9] hhh --- src/SlimFaas/ReplicasService.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SlimFaas/ReplicasService.cs b/src/SlimFaas/ReplicasService.cs index 6850b2d3..3ec439cf 100644 --- a/src/SlimFaas/ReplicasService.cs +++ b/src/SlimFaas/ReplicasService.cs @@ -136,7 +136,7 @@ public async Task CheckScaleAsync(string kubeNamespace) TimeSpan.FromSeconds( GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)) - TimeSpan.FromTicks(DateTime.UtcNow.Ticks); - logger.LogInformation("Time elapsed without request for {Deployment} is {TimeElapsedWithoutRequest}s", deploymentInformation.Deployment, time.Seconds); + logger.LogInformation("Time without request for {Deployment} is {TimeElapsedWithoutRequest}s", deploymentInformation.Deployment, time.Seconds); } int currentScale = deploymentInformation.Replicas; if (timeElapsedWithoutRequest) From 82a83fb1f480687b2d35eb1d0c60ff27fc786d11 Mon Sep 17 00:00:00 2001 From: Guillaume Chervet Date: Sun, 30 Jun 2024 15:19:34 +0200 Subject: [PATCH 4/9] sdsdds --- src/SlimFaas/ReplicasService.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/SlimFaas/ReplicasService.cs b/src/SlimFaas/ReplicasService.cs index 3ec439cf..a163570d 100644 --- a/src/SlimFaas/ReplicasService.cs +++ b/src/SlimFaas/ReplicasService.cs @@ -126,9 +126,9 @@ public async Task CheckScaleAsync(string kubeNamespace) tickLastCall = ticksLastCall[information.Deployment]; } - + var timeToWaitSeconds = TimeSpan.FromSeconds(GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)); bool timeElapsedWithoutRequest = TimeSpan.FromTicks(tickLastCall) + - TimeSpan.FromSeconds(GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)) < TimeSpan.FromTicks(DateTime.UtcNow.Ticks); + timeToWaitSeconds < TimeSpan.FromTicks(DateTime.UtcNow.Ticks); if (logger.IsEnabled(LogLevel.Information)) { @@ -136,7 +136,7 @@ public async Task CheckScaleAsync(string kubeNamespace) TimeSpan.FromSeconds( GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)) - TimeSpan.FromTicks(DateTime.UtcNow.Ticks); - logger.LogInformation("Time without request for {Deployment} is {TimeElapsedWithoutRequest}s", deploymentInformation.Deployment, time.Seconds); + logger.LogInformation("Time without request for {Deployment} is {TimeElapsedWithoutRequest}s {TickLastCall} {TimeToWait}" , deploymentInformation.Deployment, time.TotalSeconds, tickLastCall, timeToWaitSeconds); } int currentScale = deploymentInformation.Replicas; if (timeElapsedWithoutRequest) From 9d179365be8eb7db46b581fe7195979373395a77 Mon Sep 17 00:00:00 2001 From: Guillaume Chervet Date: Sun, 30 Jun 2024 15:38:54 +0200 Subject: [PATCH 5/9] update --- src/SlimFaas/ReplicasService.cs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/SlimFaas/ReplicasService.cs b/src/SlimFaas/ReplicasService.cs index a163570d..dc36d701 100644 --- a/src/SlimFaas/ReplicasService.cs +++ b/src/SlimFaas/ReplicasService.cs @@ -127,16 +127,15 @@ public async Task CheckScaleAsync(string kubeNamespace) } var timeToWaitSeconds = TimeSpan.FromSeconds(GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)); - bool timeElapsedWithoutRequest = TimeSpan.FromTicks(tickLastCall) + - timeToWaitSeconds < TimeSpan.FromTicks(DateTime.UtcNow.Ticks); + bool timeElapsedWithoutRequest = (TimeSpan.FromTicks(tickLastCall) + + timeToWaitSeconds) < TimeSpan.FromTicks(DateTime.UtcNow.Ticks); if (logger.IsEnabled(LogLevel.Information)) { - var time = TimeSpan.FromTicks(tickLastCall) + - TimeSpan.FromSeconds( - GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)) - + var time = (TimeSpan.FromTicks(tickLastCall) + + timeToWaitSeconds) - TimeSpan.FromTicks(DateTime.UtcNow.Ticks); - logger.LogInformation("Time without request for {Deployment} is {TimeElapsedWithoutRequest}s {TickLastCall} {TimeToWait}" , deploymentInformation.Deployment, time.TotalSeconds, tickLastCall, timeToWaitSeconds); + logger.LogInformation("Time without request for {Deployment} is {TimeElapsedWithoutRequest}s {TickLastCall} {TimeToWait}" , deploymentInformation.Deployment, time, tickLastCall, timeToWaitSeconds); } int currentScale = deploymentInformation.Replicas; if (timeElapsedWithoutRequest) From 075d1f7e86a2ed946525cad1dc4e2a4f1367cbf7 Mon Sep 17 00:00:00 2001 From: Guillaume Chervet Date: Sun, 30 Jun 2024 15:41:38 +0200 Subject: [PATCH 6/9] update --- src/SlimFaas/ReplicasService.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SlimFaas/ReplicasService.cs b/src/SlimFaas/ReplicasService.cs index dc36d701..ad094199 100644 --- a/src/SlimFaas/ReplicasService.cs +++ b/src/SlimFaas/ReplicasService.cs @@ -135,7 +135,7 @@ public async Task CheckScaleAsync(string kubeNamespace) var time = (TimeSpan.FromTicks(tickLastCall) + timeToWaitSeconds) - TimeSpan.FromTicks(DateTime.UtcNow.Ticks); - logger.LogInformation("Time without request for {Deployment} is {TimeElapsedWithoutRequest}s {TickLastCall} {TimeToWait}" , deploymentInformation.Deployment, time, tickLastCall, timeToWaitSeconds); + logger.LogInformation("Time without request for {Deployment} is {TimeElapsedWithoutRequest}s {TickLastCall} {TimeToWait}" , deploymentInformation.Deployment, time, TimeSpan.FromTicks(tickLastCall) - TimeSpan.FromTicks(DateTime.UtcNow.Ticks), timeToWaitSeconds); } int currentScale = deploymentInformation.Replicas; if (timeElapsedWithoutRequest) From dc119e2dc154ecd3058766af913680a878986800 Mon Sep 17 00:00:00 2001 From: Guillaume Chervet Date: Sun, 30 Jun 2024 15:58:56 +0200 Subject: [PATCH 7/9] sssssssss --- src/SlimFaas/ReplicasService.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/SlimFaas/ReplicasService.cs b/src/SlimFaas/ReplicasService.cs index ad094199..b9e9f68e 100644 --- a/src/SlimFaas/ReplicasService.cs +++ b/src/SlimFaas/ReplicasService.cs @@ -111,7 +111,7 @@ public async Task CheckScaleAsync(string kubeNamespace) } var lastTicksFromSchedule = GetLastTicksFromSchedule(deploymentInformation, DateTime.UtcNow); - if (lastTicksFromSchedule > tickLastCall) + if (lastTicksFromSchedule.HasValue && lastTicksFromSchedule > tickLastCall) { tickLastCall = lastTicksFromSchedule.Value; } @@ -135,7 +135,7 @@ public async Task CheckScaleAsync(string kubeNamespace) var time = (TimeSpan.FromTicks(tickLastCall) + timeToWaitSeconds) - TimeSpan.FromTicks(DateTime.UtcNow.Ticks); - logger.LogInformation("Time without request for {Deployment} is {TimeElapsedWithoutRequest}s {TickLastCall} {TimeToWait}" , deploymentInformation.Deployment, time, TimeSpan.FromTicks(tickLastCall) - TimeSpan.FromTicks(DateTime.UtcNow.Ticks), timeToWaitSeconds); + logger.LogInformation("Time without request for {Deployment} is {TimeElapsedWithoutRequest}s {TickLastCall} {TimeToWait}" , deploymentInformation.Deployment, time, TimeSpan.FromTicks(tickLastCall - DateTime.UtcNow.Ticks), timeToWaitSeconds); } int currentScale = deploymentInformation.Replicas; if (timeElapsedWithoutRequest) From ab877f0c3f32202a4c46d664c4bcb2337a74e5e0 Mon Sep 17 00:00:00 2001 From: Guillaume Chervet Date: Sun, 30 Jun 2024 16:18:31 +0200 Subject: [PATCH 8/9] update --- src/SlimFaas/ReplicasService.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/SlimFaas/ReplicasService.cs b/src/SlimFaas/ReplicasService.cs index b9e9f68e..6febdd23 100644 --- a/src/SlimFaas/ReplicasService.cs +++ b/src/SlimFaas/ReplicasService.cs @@ -126,6 +126,8 @@ public async Task CheckScaleAsync(string kubeNamespace) tickLastCall = ticksLastCall[information.Deployment]; } + logger.LogInformation("CheckScaleAsync {Deployment} {TickLastCall}", deploymentInformation.Deployment, tickLastCall); + logger.LogInformation("CheckScaleAsync {Deployment} {TimeToWait}", deploymentInformation.Deployment, DateTime.UtcNow.Ticks); var timeToWaitSeconds = TimeSpan.FromSeconds(GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)); bool timeElapsedWithoutRequest = (TimeSpan.FromTicks(tickLastCall) + timeToWaitSeconds) < TimeSpan.FromTicks(DateTime.UtcNow.Ticks); From ba1625dd6608b3e14a0d8878659730687568fc3e Mon Sep 17 00:00:00 2001 From: Guillaume Chervet Date: Mon, 1 Jul 2024 10:42:41 +0200 Subject: [PATCH 9/9] update log level --- src/SlimFaas/HistorySynchronizationWorker.cs | 4 ++-- src/SlimFaas/ReplicasService.cs | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/SlimFaas/HistorySynchronizationWorker.cs b/src/SlimFaas/HistorySynchronizationWorker.cs index 9680881b..0012296d 100644 --- a/src/SlimFaas/HistorySynchronizationWorker.cs +++ b/src/SlimFaas/HistorySynchronizationWorker.cs @@ -29,12 +29,12 @@ protected override async Task ExecuteAsync(CancellationToken stoppingToken) long ticksMemory = historyHttpMemoryService.GetTicksLastCall(function.Deployment); if (ticksInDatabase > ticksMemory) { - logger.LogInformation("HistorySynchronizationWorker: Synchronizing history for {Function} to {Ticks} from Database", function.Deployment, ticksInDatabase); + logger.LogDebug("HistorySynchronizationWorker: Synchronizing history for {Function} to {Ticks} from Database", function.Deployment, ticksInDatabase); historyHttpMemoryService.SetTickLastCall(function.Deployment, ticksInDatabase); } else if (ticksInDatabase < ticksMemory) { - logger.LogInformation("HistorySynchronizationWorker: Synchronizing history for {Function} to {Ticks} from Memory", function.Deployment, ticksMemory); + logger.LogDebug("HistorySynchronizationWorker: Synchronizing history for {Function} to {Ticks} from Memory", function.Deployment, ticksMemory); await historyHttpDatabaseService.SetTickLastCallAsync(function.Deployment, ticksMemory); } } diff --git a/src/SlimFaas/ReplicasService.cs b/src/SlimFaas/ReplicasService.cs index 6febdd23..306df9e8 100644 --- a/src/SlimFaas/ReplicasService.cs +++ b/src/SlimFaas/ReplicasService.cs @@ -126,18 +126,18 @@ public async Task CheckScaleAsync(string kubeNamespace) tickLastCall = ticksLastCall[information.Deployment]; } - logger.LogInformation("CheckScaleAsync {Deployment} {TickLastCall}", deploymentInformation.Deployment, tickLastCall); - logger.LogInformation("CheckScaleAsync {Deployment} {TimeToWait}", deploymentInformation.Deployment, DateTime.UtcNow.Ticks); var timeToWaitSeconds = TimeSpan.FromSeconds(GetTimeoutSecondBeforeSetReplicasMin(deploymentInformation, DateTime.UtcNow)); bool timeElapsedWithoutRequest = (TimeSpan.FromTicks(tickLastCall) + timeToWaitSeconds) < TimeSpan.FromTicks(DateTime.UtcNow.Ticks); - if (logger.IsEnabled(LogLevel.Information)) + if (logger.IsEnabled(LogLevel.Debug)) { var time = (TimeSpan.FromTicks(tickLastCall) + - timeToWaitSeconds) - + timeToWaitSeconds) - TimeSpan.FromTicks(DateTime.UtcNow.Ticks); - logger.LogInformation("Time without request for {Deployment} is {TimeElapsedWithoutRequest}s {TickLastCall} {TimeToWait}" , deploymentInformation.Deployment, time, TimeSpan.FromTicks(tickLastCall - DateTime.UtcNow.Ticks), timeToWaitSeconds); + logger.LogDebug( + "Time left without request for scale down {Deployment} is {TimeElapsedWithoutRequest}", + deploymentInformation.Deployment, time); } int currentScale = deploymentInformation.Replicas; if (timeElapsedWithoutRequest)