fix: misleading error message in PublicState::read

[Maddiaa0]

Apply aayush's fix on head

[jeanmon]

Little step for the code huge step for debugging :-)

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_trial_decrypting_time_in_ms (5): 389 (+219%)
• note_trial_decrypting_time_in_ms (32): 105 (+177%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 7438db31 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,380	179,492	716,036
l1_rollup_calldata_gas	221,168	865,940	3,446,264
l1_rollup_execution_gas	928,940	3,899,754	24,032,735
l2_block_processing_time_in_ms	1,427 (+2%)	5,425 (-1%)	22,237 (+3%)
note_successful_decrypting_time_in_ms	310 (-1%)	978 (+7%)	3,424 (+3%)
note_trial_decrypting_time_in_ms	19.8 (-9%)	⚠️ 105 (+177%)	138 (+1%)
l2_block_building_time_in_ms	16,208 (+1%)	64,137	258,386 (+1%)
l2_block_rollup_simulation_time_in_ms	11,787 (+1%)	46,742 (+1%)	188,411 (+1%)
l2_block_public_tx_process_time_in_ms	4,381 (+1%)	17,293	69,559 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	16,802 (+4%)	31,776 (+5%)
note_history_successful_decrypting_time_in_ms	2,291 (+5%)	4,508 (+5%)
note_history_trial_decrypting_time_in_ms	⚠️ 389 (+219%)	226 (+28%)
node_database_size_in_bytes	3,580,403	3,640,980
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	213	44,681	25,561
private-kernel-ordering	166 (+1%)	43,753	14,809
base-rollup	1,196	128,338	881
root-rollup	79.3	4,088	677
private-kernel-inner	293	71,208	25,561
public-kernel-private-input	206	31,863	25,561
public-kernel-non-first-iteration	204	31,905	25,561
merge-rollup	7.77 (+2%)	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	13.0 (+5%)	21.0 (-2%)	13.6	21.5 (+6%)	26.3 (+4%)	67.6 (+3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.635 (+2%)	0.653 (-3%)	0.548 (-1%)	0.543 (-1%)	0.485	0.445 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	100 (+9%)	52.8 (+3%)	256 (+3%)	484 (+1%)	926	3,590 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.519 (+5%)	0.497 (+1%)	0.446 (+2%)	0.436	0.431 (-1%)	0.428
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	127	65.5 (+5%)	385 (+3%)	792 (+4%)	1,470 (+2%)	6,010 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.519 (+2%)	0.508 (+1%)	0.489 (+2%)	0.485 (+1%)	0.478	0.486
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	70.7 (+4%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.599	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,455	32,219

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	378 (-6%)	1,091 (+1%)

Metric	1 public data writes
tx_sequencer_processing_time_ms	540 (+1%)