Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate verification key on contract deployment #4450

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

TomAFrench
Copy link
Member

This PR updates the verifier contract so that we only verify that the verification key's points lie on the bn254 curve on deployment as it's assumed that loadVerificationKey loads a constant verification key.

@AztecBot
Copy link
Collaborator

AztecBot commented Feb 6, 2024

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 92fb2b09 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,636 180,516 720,036
l1_rollup_calldata_gas 222,216 871,116 3,465,564
l1_rollup_execution_gas 314,703 988,856 3,685,221
l2_block_processing_time_in_ms 1,164 (+1%) 4,388 (+1%) 17,187 (-1%)
note_successful_decrypting_time_in_ms 308 (+2%) 1,011 (+4%) 3,662
note_trial_decrypting_time_in_ms 21.3 (+47%) 42.2 (-60%) 148 (+1%)
l2_block_building_time_in_ms 17,979 71,023 285,336
l2_block_rollup_simulation_time_in_ms 13,139 51,807 208,607
l2_block_public_tx_process_time_in_ms 4,813 (-2%) 19,132 (+1%) 76,463

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 13,780 (+1%) 26,664 (+1%)
note_history_successful_decrypting_time_in_ms 2,496 4,661 (+2%)
note_history_trial_decrypting_time_in_ms 92.7 (+13%) 225 (+7%)
node_database_size_in_bytes 17,338,448 32,989,264
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 309 44,476 26,153
private-kernel-ordering 198 (-1%) 44,473 16,553
base-rollup 1,407 128,930 881
root-rollup 82.4 4,088 677
private-kernel-inner 444 71,607 26,153
public-kernel-private-input 247 32,563 26,153
public-kernel-non-first-iteration 247 32,605 26,153
merge-rollup 7.62 2,608 881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.2 11.4 (+1%) 12.9 (+1%) 16.9 (-2%) 22.8 63.8 (-2%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 143 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.596 0.634 (+1%) 0.549 (+1%) 0.523 (-2%) 0.478 0.441 (-1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 74.9 (+1%) 47.7 239 462 905 3,543 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 159 96.0 543 1,055 2,079 8,223
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.463 (+1%) 0.490 0.436 0.432 0.430 0.426 (-1%)
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 104 (+1%) 57.1 (+1%) 353 (+1%) 691 (+1%) 1,373 (+1%) 5,400 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 197 104 691 1,363 2,707 10,771
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.492 0.499 (+1%) 0.477 0.474 0.476 (+1%) 0.470 (-1%)
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 56.7 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A 94.1 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A 0.579 N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 17,187 39,991

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 560 (+1%) 1,318
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 0.527 (-1%) 593

Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@TomAFrench TomAFrench merged commit 00f9966 into master Feb 6, 2024
83 checks passed
@TomAFrench TomAFrench deleted the tf/check-verification-key-on-deploy branch February 6, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants