Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Keys_Nullifier): Showcase full nullifier key rotation #6296

Closed
Tracked by #5606
LHerskind opened this issue May 9, 2024 · 1 comment · Fixed by #6405
Closed
Tracked by #5606

test(Keys_Nullifier): Showcase full nullifier key rotation #6296

LHerskind opened this issue May 9, 2024 · 1 comment · Fixed by #6405
Assignees

Comments

@LHerskind
Copy link
Contributor

LHerskind commented May 9, 2024

The key registry allows rotating the nullifier key, however, the caching done in the private_context in request_app_nullifier_secret_key means that only one key could be requested within the same call. This means that you cannot spend notes with different nullifier keys during the same call, as the assertions will fail.

I propose that we cache the latest, such that we don't insert repetitive requests, but allow making multiple request to ensure that we properly support key rotation.

To showcase the issue, I think it is useful to create a separate test that is receiving tokens, rotating the key and then receiving more and finally trying to send it all.

When showcased we can fix it as well.

Addressing this fits well with #6313.

@LHerskind LHerskind changed the title test(Keys_Incoming): Showacse full key rotation test(Keys_Incoming): Showcase full nullifier key rotation May 9, 2024
@LHerskind
Copy link
Contributor Author

Should wait until #6130 is in to properly test with tokens.

@LHerskind LHerskind changed the title test(Keys_Incoming): Showcase full nullifier key rotation test(Keys_Nullifier): Showcase full nullifier key rotation May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants