Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ultra goblin --> mega #6674

Merged
merged 4 commits into from
May 24, 2024
Merged

chore: ultra goblin --> mega #6674

merged 4 commits into from
May 24, 2024

Conversation

ledwards2225
Copy link
Contributor

@ledwards2225 ledwards2225 commented May 24, 2024

Naming update: UltraGoblin --> Mega

@ledwards2225 ledwards2225 self-assigned this May 24, 2024
@ledwards2225 ledwards2225 marked this pull request as ready for review May 24, 2024 17:49
* Sporadic failure of GoblinRecursionTests.Vanilla ([#6218](https://github.com/AztecProtocol/aztec-packages/issues/6218)) ([f4ecea5](https://github.com/AztecProtocol/aztec-packages/commit/f4ecea5a83bcc88fd11698ac5c8e174c2461a74b))

- Correct circuit size estimation for UltraHonk ([#6164](https://github.com/AztecProtocol/aztec-packages/issues/6164)) ([ed84fe3](https://github.com/AztecProtocol/aztec-packages/commit/ed84fe3bcc29c69b1e9d9caafd2c2c2134a67dce))
- Sporadic failure of GoblinRecursionTests.Vanilla ([#6218](https://github.com/AztecProtocol/aztec-packages/issues/6218)) ([f4ecea5](https://github.com/AztecProtocol/aztec-packages/commit/f4ecea5a83bcc88fd11698ac5c8e174c2461a74b))

### Miscellaneous

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change changelog here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, fixed.

@AztecBot
Copy link
Collaborator

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256 5,723 1,554 713 770 (-2%) 780 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412 1,412
l1_rollup_calldata_gas 9,440 9,464 9,476
l1_rollup_execution_gas 616,081 616,105 616,117
l2_block_processing_time_in_ms 1,283 (+1%) 4,790 (+2%) 9,536
l2_block_building_time_in_ms 46,712 (+2%) 185,729 (+3%) 370,373 (+1%)
l2_block_rollup_simulation_time_in_ms 46,545 (+2%) 185,107 (+3%) 369,137 (+1%)
l2_block_public_tx_process_time_in_ms 24,824 (+2%) 104,538 (+3%) 212,513 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 9,499 (-2%) 14,527 (-1%)
node_database_size_in_bytes 14,487,632 21,360,720
pxe_database_size_in_bytes 18,071 29,868

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 163 (+1%) 3,547 (+2%) 25,847 (+6%) 20,630 64,614 89,536 2,731 1,048,576
private-kernel-inner 620 4,092 (+3%) 50,461 (-2%) 92,318 64,614 89,536 2,731 2,097,152
private-kernel-tail 543 2,780 (+2%) 41,248 (-7%) 90,237 77,498 10,656 266 2,097,152
base-parity 6.42 1,264 (+9%) 2,886 (+4%) 128 64.0 2,208 2.00 131,072
root-parity 48.4 64.5 (-21%) 50,128 (-1%) 27,084 64.0 2,720 18.0 2,097,152
base-rollup 773 (-3%) 2,442 (+2%) 87,536 (+5%) 119,610 756 3,648 47.0 4,194,304
root-rollup 111 (-1%) 81.2 (+10%) 24,587 (+14%) 25,297 620 3,456 41.0 1,048,576
public-kernel-app-logic 524 2,958 (+5%) 50,887 104,941 86,302 114,784 3,520 2,097,152
public-kernel-tail 1,191 (+1%) 22,269 (-1%) 183,363 (+4%) 395,386 7,522 10,656 266 8,388,608
private-kernel-reset-small 591 (+1%) 2,042 53,021 (+9%) 120,733 64,614 89,536 2,731 2,097,152
merge-rollup 28.7 N/A N/A 16,534 756 N/A N/A N/A
public-kernel-setup 602 (-2%) N/A N/A 104,941 86,302 N/A N/A N/A
public-kernel-teardown 509 (-2%) N/A N/A 104,941 86,302 N/A N/A N/A
private-kernel-tail-to-public N/A 8,134 (-1%) 99,531 (+7%) N/A N/A 114,784 3,520 4,194,304

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,344 9,944 461 (+2%) N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,408 9,944 40.7 N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,920 9,944 1,424 (+1%) N/A N/A N/A N/A
SchnorrAccount:constructor 1,312 9,944 992 N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,304 9,944 2,108 (+1%) 16,768 50,863 (+2%) 2,097,152 457
Token:privately_mint_private_note 1,280 9,944 1,099 (-1%) N/A N/A N/A N/A
Token:transfer 1,376 9,944 3,981 (-1%) 16,768 50,883 (-8%) 2,097,152 457
Benchmarking:create_note 1,312 9,944 981 (+1%) N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,344 9,944 219 (-4%) N/A N/A N/A N/A
SchnorrAccount:spend_private_authwit 1,280 9,944 75.1 (-3%) N/A N/A N/A N/A
Token:unshield 1,376 9,944 3,209 (-1%) N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,376 9,944 3,967 (-2%) N/A N/A N/A N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.4 (+1%) 16.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.604 (+1%) 0.515 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 48.2 75.8 248 (+4%) 473 (-2%) 929 (+3%) 1,840 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.492 0.467 0.449 (+4%) 0.441 (-1%) 0.440 (+3%) 0.439 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 58.0 (+1%) 112 (+1%) 355 (+3%) 696 (-1%) 1,382 (+2%) 2,756 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 106 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.502 (+1%) 0.503 (+1%) 0.481 (+3%) 0.478 (-1%) 0.478 (+2%) 0.478 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 62.1
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 107
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.550

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 83,794 665,117

Transaction size based on fee payment method

| Metric | |
| - | |

@ludamad ludamad merged commit d272abd into master May 24, 2024
84 checks passed
@ludamad ludamad deleted the lde/mega branch May 24, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants