feat: nomismatokopio #8940
Merged
feat: nomismatokopio #8940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @LHerskind and the rest of your teammates on |
LHerskind
force-pushed
the
lh/8135-nomismatokopio
branch
from
d9bb3d2
to
5f14124
Compare
LHerskind
force-pushed
the
lh/8135-nomismatokopio
branch
from
5f14124
to
525fefe
Compare
Open
just-mitch
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Big +1 on this test layout. Huge improvements.
just-mitch
reviewed
Oct 9, 2024
| nom.mint(address(0xdead), 1); | ||
| } | ||
|
|
||
| modifier givenCallerIsOwner() { |
There was a problem hiding this comment.
Nit, comment would be nice that this should be empty because the base contract test deployed it.
just-mitch
reviewed
Oct 9, 2024
| // it emits a {Transfer} event | ||
| // it will return 0 for mintAvailable in same block | ||
| uint256 amount = bound(_amount, 1, maxMint); | ||
| assertGt(amount, 0); |
just-mitch
approved these changes
Oct 9, 2024
LHerskind
force-pushed
the
lh/8135-nomismatokopio
branch
from
525fefe
to
5d53711
Compare
Maddiaa0
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8135.
.solhintas well do remove thegas-custom-errorsrule and turn offcustom-error-over-require.The solhint version used in the docker is not the same as if using
yarn lintso need to handle that in a separate PR as there is a bunch of warnings and errors.