feat: World State Re-orgs #9035
Conversation
…ges into ag/world-state
…ges into ag/world-state
This PR fixes a bug in the block synbc process of indexed trees
| ); | ||
| }; | ||
|
|
||
| const compareSnapshots = async (left: MerkleTreeReadOperations, right: MerkleTreeReadOperations) => { |
There was a problem hiding this comment.
Isn't this the same code as compareChains above? Either way, I'd move this to test utils, and loop over MerkleTreeId to make it more manageable.
| if (blockNumber == 0) { | ||
| throw std::runtime_error("Invalid block number"); | ||
| } |
There was a problem hiding this comment.
Don't we ever request the sibling path for the genesis block (0) on the archive tree? Seems not, since this is not blowing up, but I'd've expected to be possible to fetch it?
There was a problem hiding this comment.
I don't believe so.
| if (blockNumber == 0) { | ||
| throw std::runtime_error("Invalid block number"); | ||
| } |
There was a problem hiding this comment.
Does this mean we cannot unwind to genesis, which means initial epoch cannot be unwound?
There was a problem hiding this comment.
Also, should we check we are not accidentally removing the finalised block, both here and when removing historical? (maybe it's checked somewhere else)
There was a problem hiding this comment.
Yes, the api here is 'off by one' compared to TS. So unwinding block 1 leaves you at block 0.
There was a problem hiding this comment.
Will protect against removing the current finalised block in either direction.
| uint32_t p = static_cast<uint32_t>(std::log2(highest_index + 1)) + 1; | ||
| index_t span = static_cast<uint32_t>(std::pow(2, p)); | ||
| uint64_t numBatches = workers_->num_threads(); | ||
| uint32_t indexPower2Ceil = static_cast<uint32_t>(std::ceil(std::log2(highest_index + 1))); |
There was a problem hiding this comment.
Maybe something like this is safer than relying on floating point?
There was a problem hiding this comment.
BB has some helpers in "numeric" that might be useful: https://github.com/AztecProtocol/aztec-packages/blob/master/barretenberg/cpp/src/barretenberg/numeric/bitop/get_msb.hpp
There was a problem hiding this comment.
Done, that's much better.
This PR adds pruning and re-org support to the native world state.