feat: native tmux-based network e2e #9036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
commented
Oct 6, 2024
| import subprocess | ||
| import json | ||
| import heapq | ||
|
|
There was a problem hiding this comment.
bundled because useful
Maddiaa0
reviewed
Oct 7, 2024
| export VALIDATOR_DISABLED="true" | ||
| export SEQ_MAX_SECONDS_BETWEEN_BLOCKS="0" | ||
| export SEQ_MIN_TX_PER_BLOCK="1" | ||
| export P2P_TCP_ANNOUNCE_ADDR="0.0.0.0:40400" |
There was a problem hiding this comment.
I recall in the past i had issues where the announce addresses was not 127.0.0.1. But I cannot recall why - writing this just incase
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
spypsy
reviewed
Oct 8, 2024
| @@ -25,7 +25,7 @@ export class DeployProvenTx<TContract extends Contract = Contract> extends Prove | |||
| */ | |||
| public override send(): DeploySentTx<TContract> { | |||
| const promise = (() => { | |||
| return this.wallet.sendTx(this); | |||
| return this.wallet.sendTx(this.getPlainDataTx()); | |||
There was a problem hiding this comment.
just checking that this was meant to be in this PR?
There was a problem hiding this comment.
Yes, this is needed to fix serialization. Signed off by grego
spypsy
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For debugging
