Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Log revert reason on publish to L1 #9067

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

spalladino
Copy link
Collaborator

If the tx to submit a block reverts, run a simulation with the same parameters to try and extract the revert reason out of it, and log it.

Review with whitespace diff off.

If the tx to submit a block reverts, run a simulation with the same
parameters to try and extract the revert reason out of it, and log it.
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Changes to circuit sizes

Generated at commit: bce44425ad0e2474e5c0f71cddb4f656cd621f2a, compared to commit: 5c77c4f63b2d69c5e28feade2056facafe859e03

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_merge_simulated 0 ➖ 0.00% +3,130 ❌ +313000.00%
public_kernel_inner_simulated 0 ➖ 0.00% +2,475 ❌ +247500.00%
private_kernel_tail_to_public_simulated 0 ➖ 0.00% +3,130 ❌ +78250.00%
public_kernel_tail_simulated 0 ➖ 0.00% +667 ❌ +66700.00%
private_kernel_init_simulated 0 ➖ 0.00% +1,973 ❌ +49325.00%
private_kernel_inner_simulated 0 ➖ 0.00% +1,973 ❌ +49325.00%
private_kernel_reset_simulated 0 ➖ 0.00% +1,973 ❌ +49325.00%
private_kernel_reset_simulated_4_4_4_4_4_4_4_4_1 0 ➖ 0.00% +1,973 ❌ +49325.00%
private_kernel_empty_simulated 0 ➖ 0.00% +667 ❌ +16675.00%
private_kernel_tail_simulated 0 ➖ 0.00% +667 ❌ +16675.00%
rollup_base_simulated 0 ➖ 0.00% +33 ❌ +3300.00%
empty_nested 0 ➖ +∞% +4 ❌ +100.00%
empty_nested_simulated 0 ➖ 0.00% +4 ❌ +100.00%
parity_base 0 ➖ 0.00% +21,130 ❌ +65.46%
private_kernel_empty 0 ➖ 0.00% +661 ❌ +19.06%
private_kernel_tail_to_public 0 ➖ 0.00% +3,095 ❌ +7.40%
private_kernel_init 0 ➖ 0.00% +1,955 ❌ +6.47%
private_kernel_tail 0 ➖ 0.00% +646 ❌ +5.91%
rollup_block_root_empty 0 ➖ 0.00% +105 ❌ +3.65%
private_kernel_inner 0 ➖ 0.00% +1,944 ❌ +3.54%
private_kernel_reset_4_4_4_4_4_4_4_4_1 0 ➖ 0.00% +1,933 ❌ +2.63%
public_kernel_merge 0 ➖ 0.00% +14,254 ❌ +1.29%
rollup_block_root 0 ➖ 0.00% +33,633 ❌ +1.19%
parity_root 0 ➖ 0.00% +44,738 ❌ +1.19%
rollup_merge 0 ➖ 0.00% +22,410 ❌ +1.18%
rollup_block_merge 0 ➖ 0.00% +22,493 ❌ +1.16%
rollup_root 0 ➖ 0.00% +22,477 ❌ +1.16%
public_kernel_tail 0 ➖ 0.00% +11,730 ❌ +0.52%
rollup_base 0 ➖ 0.00% +15,095 ❌ +0.43%
private_kernel_reset 0 ➖ 0.00% +1,873 ❌ +0.40%
public_kernel_inner 0 ➖ 0.00% +1,728 ❌ +0.33%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_merge_simulated 1 (0) 0.00% 3,131 (+3,130) +313000.00%
public_kernel_inner_simulated 1 (0) 0.00% 2,476 (+2,475) +247500.00%
private_kernel_tail_to_public_simulated 1 (0) 0.00% 3,134 (+3,130) +78250.00%
public_kernel_tail_simulated 1 (0) 0.00% 668 (+667) +66700.00%
private_kernel_init_simulated 1 (0) 0.00% 1,977 (+1,973) +49325.00%
private_kernel_inner_simulated 1 (0) 0.00% 1,977 (+1,973) +49325.00%
private_kernel_reset_simulated 1 (0) 0.00% 1,977 (+1,973) +49325.00%
private_kernel_reset_simulated_4_4_4_4_4_4_4_4_1 1 (0) 0.00% 1,977 (+1,973) +49325.00%
private_kernel_empty_simulated 1 (0) 0.00% 671 (+667) +16675.00%
private_kernel_tail_simulated 1 (0) 0.00% 671 (+667) +16675.00%
rollup_base_simulated 1 (0) 0.00% 34 (+33) +3300.00%
empty_nested 0 (0) +∞% 8 (+4) +100.00%
empty_nested_simulated 1 (0) 0.00% 8 (+4) +100.00%
parity_base 5,371 (0) 0.00% 53,408 (+21,130) +65.46%
private_kernel_empty 670 (0) 0.00% 4,129 (+661) +19.06%
private_kernel_tail_to_public 29,831 (0) 0.00% 44,919 (+3,095) +7.40%
private_kernel_init 24,901 (0) 0.00% 32,162 (+1,955) +6.47%
private_kernel_tail 4,745 (0) 0.00% 11,573 (+646) +5.91%
rollup_block_root_empty 93 (0) 0.00% 2,980 (+105) +3.65%
private_kernel_inner 43,951 (0) 0.00% 56,831 (+1,944) +3.54%
private_kernel_reset_4_4_4_4_4_4_4_4_1 34,899 (0) 0.00% 75,549 (+1,933) +2.63%
public_kernel_merge 53,488 (0) 0.00% 1,117,793 (+14,254) +1.29%
rollup_block_root 4,154 (0) 0.00% 2,870,753 (+33,633) +1.19%
parity_root 5,399 (0) 0.00% 3,819,849 (+44,738) +1.19%
rollup_merge 3,671 (0) 0.00% 1,918,477 (+22,410) +1.18%
rollup_block_merge 20,255 (0) 0.00% 1,954,063 (+22,493) +1.16%
rollup_root 20,239 (0) 0.00% 1,954,031 (+22,477) +1.16%
public_kernel_tail 259,172 (0) 0.00% 2,281,716 (+11,730) +0.52%
rollup_base 671,887 (0) 0.00% 3,541,069 (+15,095) +0.43%
private_kernel_reset 91,935 (0) 0.00% 472,006 (+1,873) +0.40%
public_kernel_inner 268,756 (0) 0.00% 518,289 (+1,728) +0.33%

@Maddiaa0 Maddiaa0 merged commit 814b6d0 into master Oct 8, 2024
50 checks passed
@Maddiaa0 Maddiaa0 deleted the palla/show-rollup-err branch October 8, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants