Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase l1 propose gas estimate #9071

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

just-mitch
Copy link
Contributor

@just-mitch just-mitch commented Oct 8, 2024

gas costs 60k per validator to setup epoch.
But we don't know how many validators we have necessarily.

@Maddiaa0 Maddiaa0 enabled auto-merge (squash) October 8, 2024 10:20
@Maddiaa0 Maddiaa0 merged commit 9d28414 into master Oct 8, 2024
50 checks passed
@Maddiaa0 Maddiaa0 deleted the mt/jack-up-l1-proposer-gas-estimate branch October 8, 2024 10:53
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Changes to circuit sizes

Generated at commit: dc0d3965a81a3cc4ef93d456e4f921096d46c7b2, compared to commit: 2c28dda02e568fddbff5e6e0337f374925445b65

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_root +21,280 ❌ +105.14% +51,786 ❌ +2.68%
rollup_block_merge +21,280 ❌ +105.06% +51,786 ❌ +2.68%
rollup_block_root_empty +32 ❌ +34.41% +32 ❌ +1.11%
rollup_block_root +32 ❌ +0.77% +32 ❌ +0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_root 41,519 (+21,280) +105.14% 1,983,340 (+51,786) +2.68%
rollup_block_merge 41,535 (+21,280) +105.06% 1,983,356 (+51,786) +2.68%
rollup_block_root_empty 125 (+32) +34.41% 2,907 (+32) +1.11%
rollup_block_root 4,186 (+32) +0.77% 2,837,152 (+32) +0.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants