feat: use s3 cache in bootstrap fast #9111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
reviewed
Oct 9, 2024
alexghr
commented
Oct 9, 2024
ludamad
reviewed
Oct 9, 2024
ludamad
reviewed
Oct 9, 2024
ludamad
reviewed
Oct 9, 2024
ludamad
reviewed
Oct 10, 2024
ludamad
reviewed
Oct 11, 2024
noir-projects/bootstrap_cache.sh
Outdated
|
|
||
| (cd ./noir-protocol-circuits && yarn && node ./scripts/generate_variants.js) |
There was a problem hiding this comment.
This is captured in cache now?
There was a problem hiding this comment.
Yes, the script creates the crates/autogenerated directory, the private_kernel_reset_dimensions.json file and root Nargo.toml. All three are part of the artifacts archive now :D
ludamad
approved these changes
Oct 11, 2024
alexghr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the cache used by
./bootstrap.sh fastfrom Dockerimages built in CircleCI to Earthly artifacts stored in an S3 bucket built during Github Action runs.The new script requires access to the
awscommand and for credentials to be set up to read from the S3 bucket.Fix #8929