Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sequencer address to metrics #9145

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Conversation

Maddiaa0
Copy link
Member

Overview

Adds sequencer address to the tracked metrics

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Maddiaa0 and the rest of your teammates on Graphite Graphite

@Maddiaa0 Maddiaa0 marked this pull request as draft October 10, 2024 11:25
@Maddiaa0 Maddiaa0 marked this pull request as ready for review October 10, 2024 11:35
@Maddiaa0 Maddiaa0 enabled auto-merge (squash) October 10, 2024 15:54
Copy link
Contributor

Changes to circuit sizes

Generated at commit: 3a7bcb4ec8338fbf0e137c50d223b02f61cb6e87, compared to commit: c3e859b86ce66d42ed04dfd1b3d82995490f74ae

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_root +34,368 ❌ +480.47% +83,965 ❌ +4.42%
rollup_block_merge +34,368 ❌ +479.40% +83,965 ❌ +4.42%
rollup_block_root_empty +64 ❌ +103.23% +64 ❌ +2.24%
rollup_block_root +64 ❌ +1.55% +64 ❌ +0.00%
public_kernel_merge -42 ✅ -0.08% -42 ✅ -0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_root 41,521 (+34,368) +480.47% 1,983,367 (+83,965) +4.42%
rollup_block_merge 41,537 (+34,368) +479.40% 1,983,383 (+83,965) +4.42%
rollup_block_root_empty 126 (+64) +103.23% 2,923 (+64) +2.24%
rollup_block_root 4,188 (+64) +1.55% 2,837,331 (+64) +0.00%
public_kernel_merge 53,490 (-42) -0.08% 1,103,560 (-42) -0.00%

@Maddiaa0 Maddiaa0 merged commit c33d38b into master Oct 10, 2024
52 checks passed
@Maddiaa0 Maddiaa0 deleted the md/add-seq-address-to-metrics branch October 10, 2024 16:23
TomAFrench added a commit that referenced this pull request Oct 10, 2024
* master: (155 commits)
  fix(ci): don't report for now on kind-network-test (#9163)
  chore(ci): disable gossip_network.test.ts (#9165)
  chore: script for deploying the spartan network (#9167)
  feat!: Brillig with a stack and conditional inlining (#8989)
  fix: spartan account pre-funding (#9161)
  chore: reenable sync test (#9160)
  feat: Browser tests for UltraHonk (#9047)
  feat: make index in inbox global (#9110)
  feat: add sequencer address to metrics (#9145)
  feat: add validator address to logs (#9143)
  refactor(avm): type aliasing for VmPublicInputs (#8884)
  feat: drop epoch duration / block times (#9149)
  feat: stable deployments for spartan (#9147)
  fix: e2e-p2p attestation timeout (#9154)
  feat!: unrevert "feat: new per-enqueued-call gas limit" (#9140)
  feat: better tracing/metrics in validator and archiver (#9108)
  chore: revert deletion of the old bbup (#9146)
  chore(docs): rewriting bbup script, refactoring bb readme for clarity (#9073)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants