feat: stable deployments for spartan #9147
Conversation
|
created #9148 r.e. logs Edi: Discussed with Adam, no need at all, logs echoed to ci job is all we need |
| [ | ||
| "/bin/bash", | ||
| "-c", | ||
| "source /shared/contracts.env && env && node --no-warnings /usr/src/yarn-project/aztec/dest/bin/index.js start --node --archiver --sequencer --pxe", | ||
| "sleep 30 && source /shared/contracts.env && env && node --no-warnings /usr/src/yarn-project/aztec/dest/bin/index.js start --node --archiver --sequencer --pxe", |
| - | | ||
| until curl -s -X POST -H 'Content-Type: application/json' \ | ||
| -d '{"jsonrpc":"2.0","method":"web3_clientVersion","params":[],"id":67}' \ | ||
| {{ include "aztec-network.ethereumHost" . }} | grep -q anvil; do |
There was a problem hiding this comment.
we are likely to change node in the future, the grep "anvil" here should probably also be configurable
|
Thanks! |
| @@ -50,7 +75,7 @@ spec: | |||
| command: | |||
| - "/bin/bash" | |||
| - "-c" | |||
| - "source /shared/contracts.env && env && node --no-warnings /usr/src/yarn-project/aztec/dest/bin/index.js start --node --archiver --sequencer" | |||
| - "sleep 10 && source /shared/contracts.env && env && node --no-warnings /usr/src/yarn-project/aztec/dest/bin/index.js start --node --archiver --sequencer" | |||
There was a problem hiding this comment.
Ideally all sleeps would be wait loops otherwise we invite mysterious flakes (and has been the culprit behind many so far), but if it gets us unblocked can be iterated on
There was a problem hiding this comment.
Yeah this is to allow the k8s DNS name to get set up. It runs before the node even starts, so shouldn't invite too much flake.
There was a problem hiding this comment.
still ideal to query k8s dns if possible, but yeah nbd
|
I added the kind-network-smoke to the default PR set |
|
trying a fix where network_test.sh just goes ahead and tries to get k8s tools |
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
* master: (155 commits) fix(ci): don't report for now on kind-network-test (#9163) chore(ci): disable gossip_network.test.ts (#9165) chore: script for deploying the spartan network (#9167) feat!: Brillig with a stack and conditional inlining (#8989) fix: spartan account pre-funding (#9161) chore: reenable sync test (#9160) feat: Browser tests for UltraHonk (#9047) feat: make index in inbox global (#9110) feat: add sequencer address to metrics (#9145) feat: add validator address to logs (#9143) refactor(avm): type aliasing for VmPublicInputs (#8884) feat: drop epoch duration / block times (#9149) feat: stable deployments for spartan (#9147) fix: e2e-p2p attestation timeout (#9154) feat!: unrevert "feat: new per-enqueued-call gas limit" (#9140) feat: better tracing/metrics in validator and archiver (#9108) chore: revert deletion of the old bbup (#9146) chore(docs): rewriting bbup script, refactoring bb readme for clarity (#9073) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] ...
A bunch of things to fix spartan deployment under the "default" values and "3-validators".
Big thing is that the 16 and 48 values file need the metrics chart to be deployed, but the smaller ones don't.
This is so that we can run the KIND tests in CI without metrics (which may be dumb, since if it fails we lose all logs).
Big fix is to sleep before the boot node and validators come up. This is to allow time for the k8s services to assign them DNS names.
Remove the limits on the nodes so they are faster.