Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamers Request Issue #15

Closed
MagiskSec opened this issue Jul 8, 2020 · 0 comments
Closed

Streamers Request Issue #15

MagiskSec opened this issue Jul 8, 2020 · 0 comments

Comments

@MagiskSec
Copy link
Contributor

MagiskSec commented Jul 8, 2020

There is a TypeError when using API->Station($station_id)->streamers()->list()

"Fatal error: Uncaught TypeError: Argument 3 passed to AzuraCast\Api\Dto\StreamerDto::__construct() must be of the type string, null given,"

This is as the AzuraCast API can return empty values for the password and comment (but the response could is still valid) when requested and as such it brings up a TypeError.

I have temporarily fixed this for myself by removing Password & Comment in the fromArray function in Dto\StreamerDto.php and instead replacing it with an empty string (my application doesn't need these urgently) and the errors are resolved but this is obviously not the proper way to fix it.

Update - Fixed it properly and made a PR ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant