Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why we need ReaderWriterLockSlim in OpenIdConnectCachingSecurityTokenProvider? #124

Open
LeTranAnhVu opened this issue Feb 25, 2022 · 1 comment

Comments

@LeTranAnhVu
Copy link

LeTranAnhVu commented Feb 25, 2022

The class OpenIdConnectCachingSecurityTokenProvider uses read/write lock of ReaderWriterLockSlim before get issuer and keys. I am wondering, why we need to use lock here? and what happen if we don't?

@mderriey
Copy link

I've done a write-up of my findings about the locking behaviour that we're confident caused a deadlock-like situation for us under enough concurrent requests.

AzureAD/microsoft-identity-web#3078.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants