From 2714d672131c4ae13ed3bb179474772547a99917 Mon Sep 17 00:00:00 2001
From: tschneid <tschneid@redhat.com>
Date: Fri, 30 Jun 2023 13:57:12 -0500
Subject: [PATCH] additional test cases

---
 .../tests/latest/unit/test_validators.py      | 47 ++++++++++++++++++-
 1 file changed, 46 insertions(+), 1 deletion(-)

diff --git a/python/az/aro/azext_aro/tests/latest/unit/test_validators.py b/python/az/aro/azext_aro/tests/latest/unit/test_validators.py
index fd964f35da8..bcae4a441af 100644
--- a/python/az/aro/azext_aro/tests/latest/unit/test_validators.py
+++ b/python/az/aro/azext_aro/tests/latest/unit/test_validators.py
@@ -783,6 +783,33 @@ def test_validate_refresh_cluster_credentials(test_description, namespace, expec
         Mock(outbound_type='Loadbalancer'),
         None
     ),
+    (
+        "Should not raise exception when key is Loadbalancer and ingress visibility private",
+        Mock(
+            outbound_type='Loadbalancer',
+            apiserver_visibility="Public",
+            ingress_visibility="Private"
+        ),
+        None
+    ),
+    (
+        "Should not raise exception when key is Loadbalancer and apiserver visibility private",
+        Mock(
+            outbound_type='Loadbalancer',
+            apiserver_visibility="Private",
+            ingress_visibility="Public"
+        ),
+        None
+    ),
+    (
+        "Should not raise exception when key is Loadbalancer and ingress/apiserver visibility private",
+        Mock(
+            outbound_type='Loadbalancer',
+            apiserver_visibility="Private",
+            ingress_visibility="Private"
+        ),
+        None
+    ),
     (
         "Should not raise exception when key is empty.",
         Mock(outbound_type=None),
@@ -798,7 +825,7 @@ def test_validate_refresh_cluster_credentials(test_description, namespace, expec
         None
     ),
     (
-        "Should raise exception with UDR and either ingress or apiserver visibility is public",
+        "Should raise exception with UDR and ingress visibility is public",
         Mock(
             outbound_type="UserDefinedRouting",
             apiserver_visibility="Private",
@@ -806,6 +833,24 @@ def test_validate_refresh_cluster_credentials(test_description, namespace, expec
         ),
         InvalidArgumentValueError
     ),
+    (
+        "Should raise exception with UDR and apiserver visibility is public",
+        Mock(
+            outbound_type="UserDefinedRouting",
+            apiserver_visibility="Public",
+            ingress_visibility="Private"
+        ),
+        InvalidArgumentValueError
+    ),
+    (
+        "Should raise exception with UDR and apiserver/ingress visibility is public",
+        Mock(
+            outbound_type="UserDefinedRouting",
+            apiserver_visibility="Public",
+            ingress_visibility="Public"
+        ),
+        InvalidArgumentValueError
+    ),
     (
         "Should raise exception when key is UserDefinedRouting and apiserver/ingress visibilities are not defined.",
         Mock(