Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new API to allow custom client options #106

Closed
zhenlan opened this issue Nov 7, 2019 · 1 comment
Closed

Add a new API to allow custom client options #106

zhenlan opened this issue Nov 7, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@zhenlan
Copy link
Contributor

zhenlan commented Nov 7, 2019

Proposed API

public AzureAppConfigurationOptions ConfigureClientOptions(Action<ConfigurationClientOptions> options)

This API should allow a user to overwirte the properties of ConfigurationClientOptions we use by default.

For example, in the case of Azure/AppConfiguration#179, the customer can do

using HttpClient client = new HttpClient(
    new HttpClientHandler()
    {
        Proxy = new WebProxy(new Uri("http://example.com"))
    });

builder.AddAzureAppConfiguration(o =>
    o.Connect(...)
     .ConfigureClientOptions(co => co.Transport = new HttpClientTransport(client));
)

Reference here.

cc: @drago-draganov @jimmyca15

@abhilasharora
Copy link
Contributor

This feature has been released as a part of version 3.0.0 of the package Microsoft.Extensions.Configuration.AzureAppConfiguration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants