Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TryRefreshAsync does not handle the case when initial configuration load has failed #145

Closed
abhilasharora opened this issue Mar 20, 2020 · 1 comment · Fixed by #152
Closed
Assignees
Labels
bug Something isn't working

Comments

@abhilasharora
Copy link
Contributor

No description provided.

@abhilasharora abhilasharora self-assigned this Mar 20, 2020
@zhenlan zhenlan added the bug Something isn't working label Mar 20, 2020
@abhilasharora
Copy link
Contributor Author

abhilasharora commented Apr 1, 2020

I'm thinking about updating the code to allow loading of initial configuration even when there are no refresh registrations. This will be helpful for scenarios where users don't intend to refresh any value, but still use the RefreshAsync method to try to recover from initial load failures. It basically allows them to catch failures during initial load, and then use refresh to trigger a retry. I can use the default 30 second refresh cache expiration here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants