Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to load configuration from snapshots #387

Closed
zhenlan opened this issue Feb 17, 2023 · 3 comments · Fixed by #422
Closed

Add support to load configuration from snapshots #387

zhenlan opened this issue Feb 17, 2023 · 3 comments · Fixed by #422
Assignees
@amerjusupovic

Comments

@zhenlan
Copy link
Contributor

zhenlan commented Feb 17, 2023

API proposal:

public AzureAppConfigurationOptions Select(string snapshotName)

cc: @avanigupta @jimmyca15 @drago-draganov
@jimmyca15
Copy link
Member

That doesn't conflict with our existing API

public AzureAppConfigurationOptions Select(string keyFilter, string labelFilter = LabelFilter.Null) ?

@zhenlan
Copy link
Contributor Author

zhenlan commented Feb 17, 2023

Good catch. It will. How about

public AzureAppConfigurationOptions SelectSnapshot(string name)

@jimmyca15
Copy link
Member

Sounds good to me.

@avanigupta avanigupta linked a pull request Jul 20, 2023 that will close this issue
Add SelectSnapshot to support loading configuration from snapshots #422
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amerjusupovic amerjusupovic

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zhenlan @jimmyca15 @amerjusupovic