Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions thrown for invalid feature flags #550

Closed
amerjusupovic opened this issue Apr 22, 2024 · 0 comments · Fixed by #551
Closed

Handle exceptions thrown for invalid feature flags #550

amerjusupovic opened this issue Apr 22, 2024 · 0 comments · Fixed by #551

Comments

@amerjusupovic
Copy link
Member

amerjusupovic commented Apr 22, 2024

Currently, the provider will throw a FormatException when processing feature flags with an invalid JSON format. However, the TryRefreshAsync method and startup do not properly handle this exception and will cause the provider to fail when an invalid feature flag is loaded. It should instead catch the exception and return false, as it does for all other known exceptions.

@amerjusupovic amerjusupovic changed the title Handle exceptions thrown for invalid feature flags on refresh Handle exceptions thrown for invalid feature flags Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant