Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict mode option for parsing of JSON values #555

Open
amerjusupovic opened this issue May 13, 2024 · 0 comments · May be fixed by #579
Open

Add strict mode option for parsing of JSON values #555

amerjusupovic opened this issue May 13, 2024 · 0 comments · May be fixed by #579
Assignees

Comments

@amerjusupovic
Copy link
Member

amerjusupovic commented May 13, 2024

Currently, if the provider attempts to parse an invalid JSON key-value with content type application/json, it will default to interpreting the key-value as a string. However, this also means there are no exceptions thrown or logging to indicate that the key-value had an invalid JSON and that the key-value now contains a string.

A potential solution is to add an option to the provider that can be enabled to either log a warning or throw an exception when loading a key-value if it can't be parsed as a JSON and has the "application/json" content type. This would be added to the AzureAppConfigurationOptions class as a boolean proprety.

@zhenlan @jimmyca15 @avanigupta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants