Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No logs with App Configuration export when 'yes' flag is setted #712

Closed
Philippe85 opened this issue Jan 27, 2023 · 10 comments
Closed

No logs with App Configuration export when 'yes' flag is setted #712

Philippe85 opened this issue Jan 27, 2023 · 10 comments
Assignees
Labels
bug Something isn't working cli Issues relating to the App Configuration Hubs CLI.

Comments

@Philippe85
Copy link

Hello,

When we export App Configuration to App Service without the 'yes' flag as this :
az appconfig kv export ...

we can get this information message :

Exporting feature flags to properties file or appservice is currently not supported.
---------------- Key Values Preview ----------------
Target configuration already contains all key-values in source. No changes will be made.

But if we use the flag '--yes' as this :
az appconfig kv export ... --yes

we don't see the information message, which is very useful.

Could you show the same logs when '--yes' flag is setted or not ?

Thanks.

@zhenlan
Copy link
Contributor

zhenlan commented Feb 1, 2023

@avanigupta what's the convention in CLI about whether warning messages should be showed when --yes is provided?

@zhenlan zhenlan added cli Issues relating to the App Configuration Hubs CLI. question labels Feb 1, 2023
@avanigupta
Copy link
Member

Warning messages are always shown by default in CLI, unless turned off by specifying --only-show-errors option.
The purpose of --yes is to disable user confirmation prompts, but we can still log print preview.

@zhenlan
Copy link
Contributor

zhenlan commented Feb 2, 2023

So sounds like we should show the warning message even with --yes?

@avanigupta
Copy link
Member

We don't show it today, but yes, we can surely add it.

@zhenlan
Copy link
Contributor

zhenlan commented Feb 2, 2023

Sounds good. Let's add it then as it doesn't sound intentional to be hidden with --yes.

@zhenlan zhenlan added bug Something isn't working and removed question labels Feb 2, 2023
@Philippe85
Copy link
Author

Very good. Thanks.

@brental
Copy link

brental commented Mar 15, 2023

This issue also seems to affect other az appconfig commands such as az appconfig kv import. Does the fix applied in Azure/azure-cli#25560 fix the issue for all az appconfig commands or is it just for the az appconfig kv export command?

It looks like it applies to all commands but just wanted to confirm.

EDIT: I now see in the description of the fix it says it is for the az appconfig kv import command as well, but is it just for those two commands?

@albertofori
Copy link
Member

albertofori commented Mar 15, 2023

This issue also seems to affect other az appconfig commands such as az appconfig kv import. Does the fix applied in Azure/azure-cli#25560 fix the issue for all az appconfig commands or is it just for the az appconfig kv export command?

It looks like it applies to all commands but just wanted to confirm.

EDIT: I now see in the description of the fix it says it is for the az appconfig kv import command as well, but is it just for those two commands?

Hello @brental As can be seen in the description, this fix updates the appconfig kv import and export commands only as these are the commands for which the logging update is applicable.

@brental
Copy link

brental commented Mar 16, 2023

Okay, thanks for getting back to me @albertofori . And thanks for the fix as well, it will be useful to have that logging on import.

@zhenlan
Copy link
Contributor

zhenlan commented Apr 3, 2023

The Fix has been merged.

@zhenlan zhenlan closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Issues relating to the App Configuration Hubs CLI.
Projects
None yet
Development

No branches or pull requests

5 participants