Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure SQL Firewall Rules IP parameters missing #763

Open
girolamom opened this issue Mar 1, 2023 · 1 comment
Open

Azure SQL Firewall Rules IP parameters missing #763

girolamom opened this issue Mar 1, 2023 · 1 comment
Labels
bug Something isn't working resource-provider issue with resource schema for pulled resources

Comments

@girolamom
Copy link

girolamom commented Mar 1, 2023

We are trying to help a customer using AzOps to Backup their Azure Infrastructure ARM configuration.
The AIM is to have history of the changes in case of accidental deletion.

We found the JSON generated form the tool missing a parameter in case of Firewall Rules applied to an Azure SQL.

To reproduce:

  • Create an Azure SQL
  • Apply a Firewall rule with a source IP Address.
  • Find the Source IP address in the generated JSON.

Here the resource in the portal:
image

Here the generated JSON:

{
"$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
"contentVersion": "1.0.0.0",
"metadata": {
"_generator": {
"name": "AzOps"
}
},
"parameters": {},
"variables": {},
"resources": [
{
"apiVersion": "2022-05-01-preview",
"name": "deletedbtest/ClientIPAddress_2023-3-1_15-26-4",
"type": "Microsoft.Sql/servers/firewallRules"
}
],
"outputs": {}
}

@Jefajers
Copy link
Member

Jefajers commented Mar 2, 2023

Thank you for reporting this!

I confirm that we see the same behavior. Ideally it should contain the additional properties
image

Example from Azure Portal Export (missing additional properties):
image

We are striving to support all resource providers in pull, but also rely on that the RPs return all the correct schema.
We are currently working on improving this to enable higher quality, but for now, it is best effort.

@Jefajers Jefajers added bug Something isn't working resource-provider issue with resource schema for pulled resources labels Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resource-provider issue with resource schema for pulled resources
Projects
None yet
Development

No branches or pull requests

2 participants