create new GCP CCP template #11185
Merged
create new GCP CCP template #11185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-prasadboke
added
Connector
|
@v-sabiraj can we please merge this? the validation error are just because this is a reference template? |
|
[heart] Austin McCollum reacted to your message:
…________________________________
From: Javier Soriano ***@***.***>
Sent: Friday, September 27, 2024 12:04:11 PM
To: Azure/Azure-Sentinel ***@***.***>
Cc: Austin McCollum ***@***.***>; Author ***@***.***>
Subject: Re: [Azure/Azure-Sentinel] create new GCP CCP template (PR #11185)
@v-sabiraj<https://github.com/v-sabiraj> can we please merge this? the validation error are just because this is a reference template?
—
Reply to this email directly, view it on GitHub<#11185 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADXUHLRNQIDJA5H3OUSLYNDZYVCTXAVCNFSM6AAAAABO2XXV4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZGEYTMNJRHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
sreedharande
approved these changes
Sep 29, 2024
v-sabiraj
previously approved these changes
Sep 30, 2024
v-atulyadav
previously approved these changes
Sep 30, 2024
austinmccollum
dismissed stale reviews from v-atulyadav and v-sabiraj
via
e05815d
|
@v-atulyadav and @v-sabiraj can you approve again? I've adjusted the json comments to pass validation. |
v-atulyadav
approved these changes
Oct 1, 2024
v-sabiraj
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
Publishing new template for GCP type CCP data connectors
Reason for Change(s):
This template will be referenced from the ReadMe.md
Version Updated:
First version
Testing Completed:
Yes by Daniel Zatakovy