Fix json encoding bug #11159
Merged
Fix json encoding bug #11159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-atulyadav
added
Playbook
niklas-recordedfuture
force-pushed
the
fix-json-encoding-bug
branch
from
ad66396
to
53514dc
Compare
There was a bug where if you had already instantiated something named "RecordedFuture-ConnectorV2" then it would use that, instead of asking you to create a new API connection for sandbox.
niklas-recordedfuture
force-pushed
the
fix-json-encoding-bug
branch
from
b18fc3a
to
1de6e93
Compare
v-prasadboke
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change(s):
RecordedFuture-Alert-Importer: Add?utm_source=recorded_futureparameter to the external links that point to the recorded future appRecordedFuture-Alert-Importer: Fix JSON serialization logicRecordedFuture-Sandbox_Enrichment-Url: Use Sandbox connector instead of regular connectorReason for Change(s):
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: