Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sophos Endpoint Data Connector via CCP #9838

Merged
merged 25 commits into from
Mar 12, 2024

Conversation

joanabmartins
Copy link
Contributor

@joanabmartins joanabmartins commented Jan 29, 2024

Change(s):

  • Updated Sophos endpoint data connector with ccp option and parser

Reason for Change(s):

  • Data Collector API is going to be deprecated
  • CCP data connector is an alternative to the function connector

Version Updated:
N/A

Testing Completed:
Need help ; connector and parser were tested, but I haven't tested them after packaging the solution. There was 1 error after packaging, related with IDs. I'm available for further explanation ms alias: joamar

Checked that the validations are passing and have addressed any issues that are present:
No

@joanabmartins joanabmartins requested review from a team as code owners January 29, 2024 14:49
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Jan 30, 2024
@v-prasadboke
Copy link
Contributor

v-prasadboke commented Jan 30, 2024

Hello @joanabmartins, Thanks for raising this PR. This PR will be investigated and we will update you about the same before 02 February, 2024.
Until then please create a custom table named as SophosEPEvents_CL at location .script/tests/KqlvalidationsTests/CustomTables

@joanabmartins
Copy link
Contributor Author

@v-prasadboke thank you. I've just added both tables SophosEPEvents_CL and SophosEPAlerts_CL

@v-prasadboke
Copy link
Contributor

Hello @joanabmartins, Trying to resolve validation errors. Will get back to you by 06 February, 2024.

@v-prasadboke
Copy link
Contributor

Hello @joanabmartins, create a custom table schema with name SophosEPEvent.json at the location
.script/tests/KqlvalidationsTests/CustomTables

@joanabmartins
Copy link
Contributor Author

Hi @v-prasadboke I'm not sure if I understand what you are asking me. I've already committed both custom tables to that location 0185777#diff-355c3a73d521e1aaca14f35fcfb04a9079449d3de241604e048592781958d3c1 per your previous ask.
do you want me to remove the _CL is that it?

@v-prasadboke
Copy link
Contributor

We need one custom table named after parser name.
While we use parser in detections or any other content, for this we need to have schema too.

@joanabmartins
Copy link
Contributor Author

@v-prasadboke thank you for clarifying! I just added that table (i'm sorry I should have given a better name for the commit )

@v-prasadboke
Copy link
Contributor

Hello @joanabmartins, can you provide sample data to test the content of the solution.

@joanabmartins
Copy link
Contributor Author

@v-prasadboke what do you mean by sample data? sample logs? or credentials so sign-in to sophos to test the connector? I'm fine either way. Should I email that to you? Thank you

@v-prasadboke
Copy link
Contributor

you can share the credentials and sample log over email
sample log should be in csv or json format needed for testing. Eventually will be ingesting the data for parser testing

@joanabmartins
Copy link
Contributor Author

@v-prasadboke great, i just shared both through email. Thank you

@v-prasadboke
Copy link
Contributor

Hello @joanabmartins, Thanks for sharing the credentials and sample data. I'll test the content and come back to you by 14 February, 2024.

@v-prasadboke
Copy link
Contributor

Hello @joanabmartins, we are facing issue while running the Data connector. Connect button doesn't appear on the connector page. We are trying to resolve the issue

@joanabmartins
Copy link
Contributor Author

joanabmartins commented Feb 14, 2024

By mistake I included the workday connector PR in this one, but we have corrected it, that is why there is a force-pushed. It is all good now :)

@v-prasadboke
Copy link
Contributor

Thanks @joanabmartins for the update. We will get back to you regarding Data connector button issue.

v-prasadboke and others added 6 commits February 21, 2024 14:20
Packaging tool didn't convert the sophostenantid parameter to a parameter, so I manually added it in maintTemplate. I also deleted the authorizationcode parameter, which was added automatically through the packaging tool - the authentication is oauth through client credentials it doesn't require authorization code
v-prasadboke
v-prasadboke previously approved these changes Mar 12, 2024
@v-atulyadav v-atulyadav merged commit 4c07611 into Azure:master Mar 12, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants