Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] BREAKING change: Rename .parameters folder to .test #1577

Closed
AlexanderSehr opened this issue Jun 23, 2022 · 2 comments · Fixed by #1612
Closed

[Feature Request] BREAKING change: Rename .parameters folder to .test #1577

AlexanderSehr opened this issue Jun 23, 2022 · 2 comments · Fixed by #1612
Assignees
Labels
[cat] organization category: organization enhancement New feature or request
Milestone

Comments

@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Jun 23, 2022

Description

As we're getting closer to the dependency reimplementation and may use .bicep files instead of parameter files, we may want to prepare this change by renaming the parameter folder.

I'd suggest .deploymentTests which should be generic enough to cover both parameter & dependency files (as it may take some time to work through all modules) - and avoid any confusion with e.g. the static validation that lives somewhere else (.global folder).

  • Other suggestions
    • .tests
    • .validation

The change itself should be relatively easy to implement and can be implemented for example side-by-side with the renaming of the arm folder #1127 .

Update

We agreed upon using '.test'.

@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] organization category: organization labels Jun 23, 2022
@AlexanderSehr AlexanderSehr changed the title [Feature Request]: Rename .parameters folder to, for example, .deploymentTest [Feature Request]: Rename .parameters folder to, for example, .deploymentTests Jun 23, 2022
@AlexanderSehr AlexanderSehr linked a pull request Jun 27, 2022 that will close this issue
4 tasks
@itpropro
Copy link
Contributor

Just adding my text from #1583:

[...] As for the folder rename, I think we should go with .test as folder name, as it would comply to most OSS frameworks and tools as well as development languages. Even if we have multiple types of tests in there, we can easily distinguish them by name or folder. [...]

@AlexanderSehr
Copy link
Contributor Author

@itpropro, we agreed on going with .test

@AlexanderSehr AlexanderSehr self-assigned this Jun 28, 2022
@AlexanderSehr AlexanderSehr changed the title [Feature Request]: Rename .parameters folder to, for example, .deploymentTests [Feature Request] BREAKING: Rename .parameters folder Jun 29, 2022
@AlexanderSehr AlexanderSehr pinned this issue Jun 29, 2022
@AlexanderSehr AlexanderSehr changed the title [Feature Request] BREAKING: Rename .parameters folder [Feature Request] BREAKING change: Rename .parameters folder Jun 29, 2022
@eriqua eriqua added this to the Release 0.7 milestone Jul 19, 2022
@eriqua eriqua changed the title [Feature Request] BREAKING change: Rename .parameters folder [Feature Request] BREAKING change: Rename .parameters folder to .test Jul 19, 2022
@AlexanderSehr AlexanderSehr unpinned this issue Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] organization category: organization enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants