Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broken link checker to wiki sync engine #465

Closed
MariusStorhaug opened this issue Nov 11, 2021 · 7 comments
Closed

Add broken link checker to wiki sync engine #465

MariusStorhaug opened this issue Nov 11, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@MariusStorhaug
Copy link
Contributor

MariusStorhaug commented Nov 11, 2021

Description

To make sure that we publish working links in the wiki, we should add a broken link checker that runs as a static code checker for all MD files under /docs.

i.e.:

@MariusStorhaug MariusStorhaug added the enhancement New feature or request label Nov 11, 2021
@rahalan rahalan added this to the v 0.4 milestone Nov 18, 2021
@ahmadabdalla ahmadabdalla self-assigned this Dec 6, 2021
@ahmadabdalla
Copy link
Contributor

Done some search on this and found: lychee to be a helpful solution meeting our requirements

@ahmadabdalla
Copy link
Contributor

Currently testing in my fork and I've using the following method:

  • Create a .lycheeignore to put in all of the exclusions we do not want to check.
  • Added it to the main linter workflow as always()

Pending:

  • With the exclusions in place, we have about 40 errors we need to fix. But will raise this internally to see how we can tackle them as there is a dependency on the readme generation script component that creates URLs that do not exist as the ARM documentation is sometimes not up to date with the api version we are using in our bicep modules

@ahmadabdalla ahmadabdalla linked a pull request Dec 6, 2021 that will close this issue
7 tasks
@ahmadabdalla
Copy link
Contributor

Had to change the internal links to use .md extension at the end so that they can be queried via the tools.
Removed it from the Linter into its own workflow

@ahmadabdalla ahmadabdalla removed a link to a pull request Dec 9, 2021
7 tasks
@rahalan rahalan modified the milestones: v 0.4, v 0.5 Feb 21, 2022
@rahalan rahalan removed this from the v 0.5 milestone Mar 30, 2022
@rahalan
Copy link
Contributor

rahalan commented Mar 31, 2022

@ahmadabdalla Can we close this issue?

@AlexanderSehr
Copy link
Contributor

@ahmadabdalla , @MariusStorhaug

@ahmadabdalla
Copy link
Contributor

We should be able to close it as we do have a capability now. @MariusStorhaug was there something specific we needed to implement besides the link check function we have today?

@MariusStorhaug
Copy link
Contributor Author

I think we are good on this. Closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants