Management Framework HLD - Phase II #550
Conversation
Merge from Azure/master
anand-kumar-subramanian
changed the title
…B access layer, common repo
…r openAPI stubs info
| func Subscribe(paths []string, q *queue.PriorityQueue, stop chan struct{}) ([]*IsSubscribeResponse, error) | ||
| func IsSubscribeSupported(paths []string) ([]*IsSubscribeResponse, error) | ||
| func Action(req ActionRequest) (ActionResponse, error) | ||
| func Bulk(req BulkRequest) (BulkResponse, error) |
There was a problem hiding this comment.
Do you have REST performance numbers to share to community? ex: add-delete-add vlan workflows etc..
REST and telemetry servers were using "DEVICE_METADATA|x509" table for server certificate configurations. This table has been deprecated now. Enhanced REST server startup script to read server certificate file path configurations from REST_SERVER table. Three more attributes - server_crt, server_key and ca_crt are introduced as described in sonic-net/SONiC#550. For backard compatibility, certificate configurations are read from old "DEVICE_METADATA|x509" table if they (server_crt, server_key and ca_crt) are not present in REST_SERVER table. Fixes bug sonic-net#4291 Signed-off-by: Sachin Holla <[email protected]>
REST and telemetry servers were using "DEVICE_METADATA|x509" table for server certificate configurations. This table has been deprecated now. Enhanced REST server startup script to read server certificate file path configurations from REST_SERVER table. Three more attributes - server_crt, server_key and ca_crt are introduced as described in sonic-net/SONiC#550. For backard compatibility, certificate configurations are read from old "DEVICE_METADATA|x509" table if they (server_crt, server_key and ca_crt) are not present in REST_SERVER table. Fixes bug #4291 Signed-off-by: Sachin Holla <[email protected]>
|
Hi @anand-kumar-subramanian |
|
@chenkelly The HLD content and the code present in Github seem to be not in sync. Recently Server moved to the OpenAPI generator (https://github.com/OpenAPITools/openapi-generator). As per 3.1.1 in HLD - "In case of OpenAPI spec, it is directly given to the OpenAPI generator to generate the REST client SDK and REST server stubs in golang. In this case the REST server takes care of validating the incoming request to be OpenAPI compliant before giving the same to Translib." The maxItems and minItems should be supported. The expectation is that generated stub should contain the validation code. |
Management Framework HLD - Phase II contains the following