-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support bringing own AKS cluster to deploy #26
Comments
@ashishonce I cannot open the link. What is the issue about? |
@marvinbuss the issue is linked to https://github.com/github/ms-ecosystem/issues/85 |
to expand : |
If we want to support attaching AKS, we should add this functionality to Azure/aml-compute. This task is compute related. |
@pulkitaggarwl for visibility , can you please put your thoughts? |
@marvinbuss We want customer be able to deploy to an existing cluster. Generally customers don't spin up a new K8S cluster for new services but instead use the same one. |
@pulkitaggarwl I do understand the use case. Existing clusters should either be attached to AML via ARM templates or via aml-compute. Handling compute related tasks in aml-deploy would be highly inconsistent, since this action is about creating docker images and deploying these to attached compute targets or just providing the image, so that it can be used with other actions, such as:
@awmatheson Do you have any recommendations? |
@pulkitaggarwl can you give your inputs on this. With these changes the action will look for the aks cluster specified inside ml workspace and also see if it is attached. |
We also need to decide on what behavior should be when the aks cluster specified in the config file is not found inside ML workspace or inside resource grp. Currently it deploys to ACI if cluster not found. Have raised a bug around this- |
@vivishno just had a chat with @pulkitaggarwl and closed on that .. we can put this into aml-compute. |
this links to this issue
https://github.com/github/ms-ecosystem/issues/85
The text was updated successfully, but these errors were encountered: