Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operations client list operation #1330

Closed
Alancere opened this issue May 9, 2024 · 4 comments · Fixed by #1348
Closed

operations client list operation #1330

Alancere opened this issue May 9, 2024 · 4 comments · Fixed by #1348
Assignees
Labels

Comments

@Alancere
Copy link
Member

Alancere commented May 9, 2024

tsp: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/standbypool/StandbyPool.Management/service.tsp#L35

  • The OperationsClient has a subscriptionID attribute
    image

  • operations list response is PagedOperation
    image

@jhendrixMSFT
Copy link
Member

This was a bug in tcgc, fixed via Azure/typespec-azure#788 and in the dev.3 version of the emitter.

@Alancere
Copy link
Member Author

Hi @jhendrixMSFT, the OperationsClient mentioned above has an additional subscriptionID attribute, which seems to have not been fixed

"@azure-tools/typespec-client-generator-core": "0.42.3"

@Alancere Alancere reopened this May 16, 2024
@jhendrixMSFT
Copy link
Member

Can you also please clarify what the issue is? I verified the original issue was fixed last week.

@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented May 16, 2024

Ok I understand the issue now, we shouldn't be propagating subscriptionID to this specific client.

The difference in OperationListResult vs PagedOperation, this comes from the tsp authoring. Maybe it can be fixed with some renaming in client.tsp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants