Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.17.0 and 3.17.0-preview1: Adds changelog and contract files #2247

Merged
merged 9 commits into from
Mar 2, 2021
Merged

3.17.0 and 3.17.0-preview1: Adds changelog and contract files #2247

merged 9 commits into from
Mar 2, 2021

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Feb 23, 2021

Pull Request Template

Description

This bumps the SDK version to 3.17.0 and 3.17.0-preview1.

3.17.0-preview1 compared to 3.17.0-preview:
image

3.17.0 compared to 3.16.0
image

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

FabianMeiswinkel
FabianMeiswinkel previously approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sboshra
sboshra previously approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

ealsur
ealsur previously approved these changes Feb 23, 2021
View reviewed changes
bchong95
bchong95 suggested changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@bchong95 bchong95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait a few days. CTL shows a bug in the marshalling between the SDK and ServiceInterop. Query team is investigating.

bchong95
bchong95 previously approved these changes Mar 1, 2021
View reviewed changes
@j82w j82w mentioned this pull request Mar 2, 2021
Closed
FabianMeiswinkel
FabianMeiswinkel approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j82w j82w merged commit eab492d into master Mar 2, 2021
@j82w j82w deleted the users/jawilley/3.17.0-preview1 branch March 2, 2021 18:02
This was referenced Mar 8, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@ealsur ealsur ealsur approved these changes

@sboshra sboshra sboshra left review comments

@kirankumarkolli kirankumarkolli kirankumarkolli left review comments

@bchong95 bchong95 bchong95 left review comments

@kirillg kirillg Awaiting requested review from kirillg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@j82w @ealsur @bchong95 @kirankumarkolli @sboshra @FabianMeiswinkel