Warnings logged on response code 304

[mortenbock]

Describe the bug
When using the change feed processor, the Cosmos api will often return status 304, to indicate that there are no changes.

This causes an error to be logged with a message about LatencyOverThreshold, which is not actually the case. The response time is below the limit, but the condition also requires that the response code .IsSuccess() which means 200-299.

This seems to be the line causing this:

azure-cosmos-dotnet-v3/Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/Filters/DiagnosticsFilterHelper.cs

Line 34 in 1981fc1

return response.Diagnostics.GetClientElapsedTime() > latencyThreshold || !response.StatusCode.IsSuccess();

Expected behavior
I would expect to only get LatencyOverThreshold warning logged when the latency threshold is exceeded.

If the response has an error code, that should be a different warning/error message, and in this case 304 status is not an error.

[ealsur]

@sourabh1007 Could you take a look?

[sourabh1007]

Thanks for pointing it out @mortenbock , fixing it as part of attached PR. it should be available in next release