From a06e2abee507a835eec45cbdd965c984aac5df22 Mon Sep 17 00:00:00 2001 From: SaurabhSharma-MSFT <38112130+SaurabhSharma-MSFT@users.noreply.github.com> Date: Mon, 11 Jul 2022 17:01:14 -0700 Subject: [PATCH 01/10] Documentation: Modify retry time to timespan Modify retry time in seconds to timespan of parameter maxRetryWaitTimeOnThrottledRequests (Method: [WithThrottlingRetryOptions](https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.cosmos.fluent.cosmosclientbuilder.withthrottlingretryoptions?view=azure-dotnet#feedback)) Resolves https://github.com/Azure/azure-sdk-for-net/issues/29567 --- Microsoft.Azure.Cosmos/src/Fluent/CosmosClientBuilder.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Microsoft.Azure.Cosmos/src/Fluent/CosmosClientBuilder.cs b/Microsoft.Azure.Cosmos/src/Fluent/CosmosClientBuilder.cs index 1e28dd5ac0..da5ce80e43 100644 --- a/Microsoft.Azure.Cosmos/src/Fluent/CosmosClientBuilder.cs +++ b/Microsoft.Azure.Cosmos/src/Fluent/CosmosClientBuilder.cs @@ -491,7 +491,7 @@ public CosmosClientBuilder AddCustomHandlers(params RequestHandler[] customHandl /// /// Sets the maximum time to wait between retry and the max number of times to retry on throttled requests. /// - /// The maximum retry time in seconds for the Azure Cosmos DB service. Any interval that is smaller than a second will be ignored. + /// The maximum retry timespan for the Azure Cosmos DB service. Any interval that is smaller than a second will be ignored. /// The number specifies the times retry requests for throttled requests. /// /// When a request fails due to a rate limiting error, the service sends back a response that @@ -704,4 +704,4 @@ internal CosmosClientBuilder WithRetryWithOptions( return this; } } -} \ No newline at end of file +} From 0d5493d186828d32c59fbd52c33217503fff5770 Mon Sep 17 00:00:00 2001 From: SaurabhSharma-MSFT <38112130+SaurabhSharma-MSFT@users.noreply.github.com> Date: Fri, 15 Jul 2022 13:49:28 -0700 Subject: [PATCH 02/10] Documentation: Fixes DeleteItemAsync Example Documentation: Fixes DeleteItemAsync Example --- Microsoft.Azure.Cosmos/src/Resource/Container/Container.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Microsoft.Azure.Cosmos/src/Resource/Container/Container.cs b/Microsoft.Azure.Cosmos/src/Resource/Container/Container.cs index d024c7209b..1defe1f3cc 100644 --- a/Microsoft.Azure.Cosmos/src/Resource/Container/Container.cs +++ b/Microsoft.Azure.Cosmos/src/Resource/Container/Container.cs @@ -845,7 +845,7 @@ public abstract Task DeleteItemStreamAsync( /// public string status {get; set;} /// } /// - /// ItemResponse item = await this.container.DeleteItemAsync("id", "partitionKey"); + /// ItemResponse item = await this.container.DeleteItemAsync("id", new PartitionKey("partitionKey")); /// ]]> /// /// From 5a2416ee52718271c4bf1d370e4441c658cb177d Mon Sep 17 00:00:00 2001 From: SaurabhSharma-MSFT <38112130+SaurabhSharma-MSFT@users.noreply.github.com> Date: Mon, 8 Aug 2022 12:46:08 -0700 Subject: [PATCH 03/10] Documentation: Fixes ItemRequestOptions Example Documentation: Fixes ItemRequestOptions Example --- .../src/RequestOptions/ItemRequestOptions.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Microsoft.Azure.Cosmos/src/RequestOptions/ItemRequestOptions.cs b/Microsoft.Azure.Cosmos/src/RequestOptions/ItemRequestOptions.cs index cfa8595e20..59b5b245f7 100644 --- a/Microsoft.Azure.Cosmos/src/RequestOptions/ItemRequestOptions.cs +++ b/Microsoft.Azure.Cosmos/src/RequestOptions/ItemRequestOptions.cs @@ -106,7 +106,7 @@ public ConsistencyLevel? ConsistencyLevel /// /// /// (tests, new PartitionKey(test.status), requestOptions); /// Assert.AreEqual(HttpStatusCode.Created, itemResponse.StatusCode); /// Assert.IsNull(itemResponse.Resource); @@ -156,4 +156,4 @@ internal override void PopulateRequestOptions(RequestMessage request) base.PopulateRequestOptions(request); } } -} \ No newline at end of file +} From 8b3afb21ee84d7474e660c2f79c2d2e3cf371900 Mon Sep 17 00:00:00 2001 From: SaurabhSharma-MSFT <38112130+SaurabhSharma-MSFT@users.noreply.github.com> Date: Tue, 13 Sep 2022 15:14:46 -0700 Subject: [PATCH 04/10] Documentation:Update Database.ReadAsync description Documentation: Update Database.ReadAsync description --- Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs b/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs index 1040472858..9e9b3a76b9 100644 --- a/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs +++ b/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs @@ -32,7 +32,8 @@ public abstract class Database public abstract CosmosClient Client { get; } /// - /// Reads a from the Azure Cosmos service as an asynchronous operation. + /// Reads a from the Azure Cosmos service as an asynchronous operation. + /// However, there is an implicit conversion from DatabaseResponse to DatabaseProperties /// /// (Optional) The options for the request. /// (Optional) representing request cancellation. From 94c979efd238f1359cf81360d56e89ed55689358 Mon Sep 17 00:00:00 2001 From: SaurabhSharma-MSFT <38112130+SaurabhSharma-MSFT@users.noreply.github.com> Date: Mon, 26 Sep 2022 17:17:36 -0700 Subject: [PATCH 05/10] Documentation: Update Database.ReadAsync description Documentation: Update Database.ReadAsync description --- Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs b/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs index 9e9b3a76b9..12e9227c11 100644 --- a/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs +++ b/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs @@ -31,9 +31,8 @@ public abstract class Database /// public abstract CosmosClient Client { get; } - /// - /// Reads a from the Azure Cosmos service as an asynchronous operation. - /// However, there is an implicit conversion from DatabaseResponse to DatabaseProperties + /// + /// Reads a from the Azure Cosmos service as an asynchronous operation. /// /// (Optional) The options for the request. /// (Optional) representing request cancellation. @@ -41,6 +40,9 @@ public abstract class Database /// A containing a which wraps a containing the read resource record. /// /// https://aka.ms/cosmosdb-dot-net-exceptions + + contains the that include the resource information. + /// /// /// Date: Mon, 26 Sep 2022 17:28:41 -0700 Subject: [PATCH 06/10] Documentation: Updated ToStreamIterator example Documentation: Updated ToStreamIterator example --- Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs b/Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs index baddf0fe31..dc86de0cb6 100644 --- a/Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs +++ b/Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs @@ -186,7 +186,7 @@ public static FeedIterator ToFeedIterator(this IQueryable query) /// /// linqQueryable = this.Container.GetItemLinqQueryable(); - /// using (FeedIterator setIterator = linqQueryable.Where(item => (item.taskNum < 100)).ToFeedIterator() + /// using (FeedIterator setIterator = linqQueryable.Where(item => (item.taskNum < 100)).ToStreamIterator()) /// ]]> /// /// From 2aff57026670358f720a236ea29a41b926e5614f Mon Sep 17 00:00:00 2001 From: SaurabhSharma-MSFT <38112130+SaurabhSharma-MSFT@users.noreply.github.com> Date: Mon, 26 Sep 2022 17:48:39 -0700 Subject: [PATCH 07/10] Modified StreamIterator section --- Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs b/Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs index dc86de0cb6..d305430021 100644 --- a/Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs +++ b/Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs @@ -174,14 +174,14 @@ public static FeedIterator ToFeedIterator(this IQueryable query) } /// - /// This extension method gets the FeedIterator from LINQ IQueryable to execute query asynchronously. - /// This will create the fresh new FeedIterator when called. + /// This extension method gets the StreamIterator from LINQ IQueryable to execute query asynchronously. + /// This will create the fresh new StreamIterator when called. /// /// the type of object to query. /// the IQueryable{T} to be converted. /// An iterator to go through the items. /// - /// This example shows how to get FeedIterator from LINQ. + /// This example shows how to get StreamIterator from LINQ. /// /// /// Date: Fri, 30 Sep 2022 11:06:33 -0700 Subject: [PATCH 08/10] Update Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs Co-authored-by: Matias Quaranta --- Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs b/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs index 12e9227c11..765b598299 100644 --- a/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs +++ b/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs @@ -40,7 +40,7 @@ public abstract class Database /// A containing a which wraps a containing the read resource record. /// /// https://aka.ms/cosmosdb-dot-net-exceptions - +/// contains the that include the resource information. /// From b67cc33f4fd6f62726e88834653697e59efafdc3 Mon Sep 17 00:00:00 2001 From: SaurabhSharma-MSFT <38112130+SaurabhSharma-MSFT@users.noreply.github.com> Date: Fri, 30 Sep 2022 11:10:55 -0700 Subject: [PATCH 09/10] Remarks correction --- Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs b/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs index 765b598299..e359c4fd52 100644 --- a/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs +++ b/Microsoft.Azure.Cosmos/src/Resource/Database/Database.cs @@ -40,9 +40,9 @@ public abstract class Database /// A containing a which wraps a containing the read resource record. /// /// https://aka.ms/cosmosdb-dot-net-exceptions -/// - contains the that include the resource information. - + /// + /// contains the that include the resource information. + /// /// /// /// Date: Thu, 8 Dec 2022 12:11:10 +0530 Subject: [PATCH 10/10] Revert the StreamIterator changes Revert the StreamIterator changes --- Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs b/Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs index d305430021..dc86de0cb6 100644 --- a/Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs +++ b/Microsoft.Azure.Cosmos/src/Linq/CosmosLinqExtensions.cs @@ -174,14 +174,14 @@ public static FeedIterator ToFeedIterator(this IQueryable query) } /// - /// This extension method gets the StreamIterator from LINQ IQueryable to execute query asynchronously. - /// This will create the fresh new StreamIterator when called. + /// This extension method gets the FeedIterator from LINQ IQueryable to execute query asynchronously. + /// This will create the fresh new FeedIterator when called. /// /// the type of object to query. /// the IQueryable{T} to be converted. /// An iterator to go through the items. /// - /// This example shows how to get StreamIterator from LINQ. + /// This example shows how to get FeedIterator from LINQ. /// /// ///