From 89ba26d93f3b8522d96fc4544b208d50b0fe88a8 Mon Sep 17 00:00:00 2001
From: Allen Zhang <allenzhang@live.com>
Date: Wed, 24 May 2023 08:26:48 -0700
Subject: [PATCH] Fixing container service warning and arm-types reference
 (#24044)

* Fixing container service warning and arm-types reference

* Add Fleet.Management to CI pipeline

* Update tspconfig.yaml to align with sample

* Update specification/containerservice/Fleet.Management/tspconfig.yaml

Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>

* Revert "Update specification/containerservice/Fleet.Management/tspconfig.yaml"

This reverts commit 6896819e7d93496efa50bc154bc52f3acfe8d34d.

* Removing last suppression

* update arm-types-dir to use absolute path. Need fixing it later

* Update arm-types-dir to correct path

* Remove arm-types-dir
- Setting matches default value

* Remove unnecessary "./" in tspconfig.yaml

---------

Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
---
 eng/pipelines/typespec-ci.yml                          |  5 +++++
 .../containerservice/Fleet.Management/fleet.tsp        | 10 +---------
 .../containerservice/Fleet.Management/tspconfig.yaml   |  7 ++++---
 3 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/eng/pipelines/typespec-ci.yml b/eng/pipelines/typespec-ci.yml
index f895daf53682..a8615a3ad466 100644
--- a/eng/pipelines/typespec-ci.yml
+++ b/eng/pipelines/typespec-ci.yml
@@ -49,6 +49,11 @@ jobs:
       Folder: specification/cognitiveservices/OpenAI.Inference
       DisplayName: OpenAI.Inference
 
+  - template: templates/steps/typespec-ci.yml
+    parameters:
+      Folder: specification/containerservice/Fleet.Management
+      DisplayName: Fleet.Management
+
   - template: templates/steps/typespec-ci.yml
     parameters:
       Folder: specification/translation/Azure.AI.TextTranslation
diff --git a/specification/containerservice/Fleet.Management/fleet.tsp b/specification/containerservice/Fleet.Management/fleet.tsp
index 022c52ffbc23..428727913a6c 100644
--- a/specification/containerservice/Fleet.Management/fleet.tsp
+++ b/specification/containerservice/Fleet.Management/fleet.tsp
@@ -107,8 +107,7 @@ interface Fleets {
   get is ArmResourceRead<Fleet>;
 
   @doc("Creates or updates a Fleet.")
-  @operationId("Fleets_CreateOrUpdate")
-  create is ArmResourceCreateOrUpdateAsync<
+  createOrUpdate is ArmResourceCreateOrUpdateAsync<
     Fleet,
     BaseParameters<Fleet> &
       IfMatchParameters<Fleet> &
@@ -121,12 +120,6 @@ interface Fleets {
     BaseParameters<Fleet> & IfMatchParameters<Fleet>
   >;
 
-  @extension(
-    "x-ms-long-running-operation-options",
-    {
-      "final-state-via": "location",
-    }
-  )
   delete is ArmResourceDeleteAsync<
     Fleet,
     BaseParameters<Fleet> & IfMatchParameters<Fleet>
@@ -135,7 +128,6 @@ interface Fleets {
   @doc("Lists fleets in the specified subscription and resource group.")
   listByResourceGroup is ArmResourceListByParent<Fleet>;
 
-  @operationId("Fleets_ListBySubscription")
   @doc("Lists fleets in the specified subscription.")
   listBySubscription is ArmListBySubscription<Fleet>;
 
diff --git a/specification/containerservice/Fleet.Management/tspconfig.yaml b/specification/containerservice/Fleet.Management/tspconfig.yaml
index c90edaf758dd..cf3eb6cf2d59 100644
--- a/specification/containerservice/Fleet.Management/tspconfig.yaml
+++ b/specification/containerservice/Fleet.Management/tspconfig.yaml
@@ -2,7 +2,8 @@ emit:
   - '@azure-tools/typespec-autorest'
 options:
   '@azure-tools/typespec-autorest':
-    azure-resource-provider-folder: '{cwd}/../resource-manager'
+    azure-resource-provider-folder: "resource-manager"
+    emitter-output-dir: "{project-root}/.."
+    examples-directory: "examples"
     output-file: "{azure-resource-provider-folder}/{service-name}/fleet/{version-status}/{version}/fleets.json"
-    examples-directory: '{cwd}/examples'
-    omit-unreachable-types: true
\ No newline at end of file
+    omit-unreachable-types: true