Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IC3 ACS Server Calling] API Review #23092

Closed
azure-sdk opened this issue Mar 15, 2023 · 1 comment · Fixed by #23091
Closed

[IC3 ACS Server Calling] API Review #23092

azure-sdk opened this issue Mar 15, 2023 · 1 comment · Fixed by #23091
Assignees
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.

Comments

@azure-sdk
Copy link
Collaborator

New API Review meeting has been requested.

Service Name: IC3 ACS Server Calling
Review Created By: Min Woo Lee
Review Date: 4/13/2023 4:00 PM PT
PR: #23091
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description:

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@azure-sdk azure-sdk added the API Review Scoping This is an issue that will track work on a specific set of API changes. label Mar 15, 2023
@tg-msft
Copy link
Member

tg-msft commented Apr 13, 2023

Notes from our discussion:

  • Consider keeping an array for add/remove participants so you have room to version in batches in the future. You can add validation there's only a single item being passed today.
    • If you're going to keep it as a single participant, you should use PUT/DELETE off the participant path
  • Spell out the acs enum value
  • Double check if external storage is meant for GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants