-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Container Apps - Azure Container Apps] API Review #30393
Comments
Notes from API Review 9/5/24 PR is actually
Please address the above issues and then schedule a follow-up since this is for GA. |
Pls provide a link to the OpenAI files APIs that this API should be compatible with. |
|
Thanks for capturing the feedback over GitHub issue and data-plane APIs review PR apart from discussion we had in the meeting. We tried to capture all responses here for all top concerns/questions were asked. Setting up common ground on what we mean by a session under session pool
[Response] Agreed and helpful feedback. We will have a clear documentation on which runtime customer will get and what's our plan for supporting them and updating it in future. In future, we will also run-time stack version under created session pool for in-place information for end-customer.
[Response] We imagine session as a data-plane resource of session pool ARM resource which gives more flexibility to us like low-latency code execution in a session like current end-to-end execution for Bing Copilot session is happening within 80 msecs. The volume of code execution calls and number of sessions created are in millions in a day so creating a persisted ARM resource for a session is setup overhead for customers. Enabling WebSocket like other TCP protocols would be possible with data-plane implementation like we are working on GPU enabled Dynamic sessions (separate from this review). Since primary use case is around LLM agents so we need to provide a support for uploading large size files for eco-system parity while ARM limit that with ~10 MB size. Storing these files directly only Storage is not intended experience for customers as often it includes sensitive data and typically meant for one-time use.
[Response] Currently, the format is: https://eastasia.dynamicsessions.io/subscriptions/cabb33e6-3c92-4907-9d7c-80c7ca9ac327/resourceGroups/aca-session-prod-deployment-1/sessionPools/my-session-pool which we return as "data-plane endpoint" provided by the service in session pool ARM resource response, should be treated as a string, and customers should configure the sessions data-plane SDKs endpoint as it is as provided by us. We will make changes in future to have a unique FQDN for each pool to further eliminate the need of serviceRoot as path parameters as mentioned by Azure DNS team here.
[Response] We internalized it and agreed to follow Azure guidelines for 1 code execution API and 5 file operation APIs (get metadata of a file, list of metadata of files, download, upload, delete a file) with keeping current Preview customers supported as it is. Code execution API can respond back with 200 OK if execution type is sync or 202 if execution type is async with additional location header information and GET API for long-poll etc. as per following LRO pattern.
Don't use foundational operations—refer to examples in the Playground or recently reviewed TypeSpec services. Avoid using Subscription ID as a model if it's already defined as a path parameter. |
New API Review meeting has been requested. Service Name: Azure Container Apps Description: Detailed meeting information and documents provided can be accessed here |
New API Review meeting has been requested.
Service Name: Azure Container Apps - Azure Container Apps
Review Created By: Rajneesh Mitharwal
Review Date: 09/05/2024 08:00 AM PT
Release Plan: 1418
PR: #29258
Hero Scenarios Link: here
Core Concepts Doc Link: here
Description: 1. Customer create a code interpreter or dedicated session pool via ARM APIs (control-plane resources)
2. Customer can expose their own APIs or other protocols via dedicated session pool. No 1P data-plane REST APIs for that.
3. We expose 1P data-plane REST APIs for code interpreter scenarios and providing support for two langs (Node JS & Python) out of box
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here
The text was updated successfully, but these errors were encountered: