Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BreakingChanges] Diff files against themselves to ensure tool doesn't crash #30543

Open
mikeharder opened this issue Sep 12, 2024 · 0 comments
Assignees

Comments

@mikeharder
Copy link
Member

The BreakingChanges check has a flaw, where it only runs on a file if there is a diff in the PR. So, if a file has a bug so severe it crashes the BreakingChanges check, it won't be detected until later, when the file is changed. This causes significant confusion, because the changes may be unrelated to the original bug.

To mitigate, check BreakingChanges should run on every file in a PR, even if the file is totally new. Any file can be compared "against itself" just to make sure the tool doesn't crash.

@mikeharder mikeharder self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant