You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These methods don't need to be virtual nor are they part of the public surface area. However, the way the tests are written, they take a dependency on this implementation detail. Additionally, because the unit tests have them mocked, they have to be marked as virtual, which they shouldn't be.
Follow-up from #5584
Currently the
RetryPolicy
has these two methods which are part of its implementation detail and being used in unit tests:ShouldRetryOnResponse
ShouldRetryOnTransportFailure
azure-sdk-for-cpp/sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp
Lines 405 to 417 in ac68505
These methods don't need to be virtual nor are they part of the public surface area. However, the way the tests are written, they take a dependency on this implementation detail. Additionally, because the unit tests have them mocked, they have to be marked as virtual, which they shouldn't be.
azure-sdk-for-cpp/sdk/core/azure-core/test/ut/retry_policy_test.cpp
Lines 107 to 126 in ac68505
The text was updated successfully, but these errors were encountered: