Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom headers for AKS #11692

Closed
jmcshane opened this issue Jul 16, 2020 · 4 comments
Closed

Support custom headers for AKS #11692

jmcshane opened this issue Jul 16, 2020 · 4 comments
Labels
AKS customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library.

Comments

@jmcshane
Copy link

Feature Request

Provide a way to specify aks-custom-headers during the creation of a cluster. This is required for setting OS level configuration as described here.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 16, 2020
@ArcturusZhang ArcturusZhang added the feature-request This issue requires a new behavior in the product in order be resolved. label Jul 17, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 17, 2020
@ArcturusZhang ArcturusZhang removed the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Jul 17, 2020
@lilyjma lilyjma added the AKS label Jul 31, 2020
@tzhanl tzhanl added the Mgmt This issue is related to a management-plane library. label Aug 27, 2020
@kingli-crypto
Copy link

Any ETA?

@ArcturusZhang
Copy link
Member

Hey @jmcshane and @kingli-crypto sorry for the delay of response.
Actually we have a way to send the request with customized headers like this (I am using a virtual machine client for demonstration here, but all clients are the same):

func main() {
	authorizer, err := auth.NewAuthorizerFromCLI()
	if err != nil {
		panic(err)
	}
	ctx := context.Background()
	client := compute.NewVirtualMachinesClient(subscriptionId)
	client.Authorizer = authorizer
	client.RequestInspector = autorest.WithHeader("header-key", "header-value")
	request := compute.VirtualMachine{}
	future, err := client.CreateOrUpdate(ctx, "group1", "vm1", request)
	if err != nil {
		panic(err)
	}
	if err := future.WaitForCompletionRef(ctx, client.Client); err != nil {
		panic(err)
	}
}

@tombuildsstuff
Copy link
Contributor

@ArcturusZhang these aren't HTTP headers, but a Key-Value field in the request/response called "custom headers" iirc

@njuCZ
Copy link
Contributor

njuCZ commented Mar 9, 2021

@tombuildsstuff after refer to the azure cli and aks team, unfortunately it's actually HTTP headers...So may I ask your opinion about issue hashicorp/terraform-provider-azurerm#6793? I am preparing a PR for it.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AKS customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

No branches or pull requests

7 participants