Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appinsights: support API version "2020-02-02-preview" #13012

Closed
khaliddermoumi opened this issue Oct 28, 2020 · 26 comments
Closed

appinsights: support API version "2020-02-02-preview" #13012

khaliddermoumi opened this issue Oct 28, 2020 · 26 comments
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Monitor - ApplicationInsights Service Attention Workflow: This issue is responsible by Azure service team.
Milestone

Comments

@khaliddermoumi
Copy link

Feature Request

Please support API version "2020-02-02-preview" for Application Insights.
There's a major new feature supported in this version, the workspace-based Application Insights resource. It allows integrating AI into a Log Analytics workspace, meaning that the Log Analytics workspace is the data back end for Application Insights.
I noticed the lack of this feature as I started implementing support for this feature in Terraform.

Thanks and kind regards.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 28, 2020
@ArcturusZhang ArcturusZhang added Monitor - ApplicationInsights Service Attention Workflow: This issue is responsible by Azure service team. labels Nov 3, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 3, 2020
@ghost
Copy link

ghost commented Nov 3, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @azmonapplicationinsights.

@ArcturusZhang ArcturusZhang added feature-request This issue requires a new behavior in the product in order be resolved. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 3, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 3, 2020
@ArcturusZhang ArcturusZhang removed the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Nov 3, 2020
@ArcturusZhang
Copy link
Member

Hi @azmonapplicationinsights could you please open a release request for the particular api-version of application insights?

@haflidif
Copy link

Hi @azmonapplicationinsights any updates ?

@tafs7
Copy link

tafs7 commented Jan 12, 2021

Any updates? @azmonapplicationinsights @ArcturusZhang

It has been nearly a month since last comment, and no news. Would be nice to know whether this is coming soon or further down the road, so others can plan accordingly.

@ArcturusZhang
Copy link
Member

Any updates? @azmonapplicationinsights @ArcturusZhang

It has been nearly a month since last comment, and no news. Would be nice to know whether this is coming soon or further down the road, so others can plan accordingly.

I just wrote some emails to the corresponding team, and we might get some updates soon! Sorry for the delay

@kibnelbachyr
Copy link

kibnelbachyr commented Jan 14, 2021

Any updates on this, please ?

@rmaziarka
Copy link

I've come across this problem today - no option to create workspace-based AI. Is there any progress in this matter?

@sebader
Copy link
Member

sebader commented Feb 24, 2021

With the now announced deprecation of the non-workspace-attached AI, this should really be prioritized
https://azure.microsoft.com/en-us/updates/we-re-retiring-classic-application-insights-on-29-february-2024/

@federicobarera
Copy link

federicobarera commented Feb 25, 2021

@ArcturusZhang Get we get an ETA on this feature please

@ArcturusZhang
Copy link
Member

Hi @federicobarera @sebader we are discussing this with the service team currently, will let you know the process very soon

@sivetic
Copy link

sivetic commented Mar 23, 2021

@ArcturusZhang Any update on this task? We are waiting on azurerm update to support the Workspace model, and it seems it keeps getting kicked down the line.

@ArcturusZhang
Copy link
Member

Hi all, the service team is working on the swagger correctness issues now, once they finish their work, we could get a release on the new api-version.

@sivetic
Copy link

sivetic commented Apr 12, 2021

@ArcturusZhang Are there any further updates you could provide?

@pauska
Copy link

pauska commented Apr 20, 2021

@ArcturusZhang Hi - are there any updates on this issue that you could share with us?

@ArcturusZhang
Copy link
Member

Hi I am sorry it took this long, but the service team is trying to resolve the correctness and completeness issues in their swagger. We have to wait for them to complete these tasks to release the corresponding SDK. I will constantly ping them for updates.

@khaliddermoumi
Copy link
Author

Hi!
Meanwhile here is an implementation of the app insights ws-based resource as a terraform module (using "az rest"):
Usage:

source = "git::[email protected]:khaliddermoumi/terraform-modules-azurerm//app_insights?ref=v0.1.1"

@sivetic
Copy link

sivetic commented Jun 14, 2021

@ArcturusZhang Can you share any progress update?

@ArcturusZhang
Copy link
Member

We have a on-going PR for the new package for application insights. Once we resolve the issues in that PR, we will release a new package.

@dylan-asos
Copy link

https://github.com/Azure/azure-sdk-for-go/releases/tag/v55.5.0 looks like it includes these changes now

@RickWinter RickWinter added this to the Backlog milestone Jul 12, 2021
@ArcturusZhang
Copy link
Member

This has been released in v55.5.0, therefore I will close this issue.

There is also a requirement that we want to make it stable, therefore in the next major version this preview will be removed and we will have a stable version of this by removing the preview APIs in it.

@dylanmorley
Copy link

@ArcturusZhang in this version of the API, the RetentionInDays property is no longer documented and has become read only in the Go SDK.

For a bit of context on the problems this causes, see this issue (see towards the end of the thread) We can no longer set the property when creating an app insights resource.

Can you confirm the reasons for the removal of this property - is this a deliberate omission, due to workspace mode support and therefore the change in which resource controls data retention settings?

Before we can make any progress on the linked issue, it would be good to understand the breaking change to the API

@timja
Copy link

timja commented Jul 20, 2021

@dylanmorley best to raise an issue on the https://github.com/Azure/azure-rest-api-specs repo.

The service team will get notified, you may also want to escalate via your account manager if you have enterprise support. (and/or via an Azure support ticket as well)

@khaliddermoumi
Copy link
Author

"Retention" is not needed anymore, as the retention is set and billed via the Log Analytics Workspace.
See: Workspace-based Application Insights resources:
"Data ingestion and retention for workspace-based Application Insights resources are billed through the Log Analytics workspace where the data is located."
That's why it doesn't make sense anymore to have the retentionInDays writable.

@dylanmorley
Copy link

@khaliddermoumi yes, but only if you set the workspace id. If you don't, then you're creating a 'classic' mode insights resource, which is in support for a few years yet - data Retention still applies for those types of resources.

Thanks @timja, will raise an issue.

@khaliddermoumi
Copy link
Author

The "2020-02-02-preview" API version can only create workspace-based resources, at least according to the docs:
"WorkspaceResourceId: Resource Id of the log analytics workspace which the data will be ingested to. This property is required to create an application with this API version. Applications from older versions will not have this property."
If this is correct, the TF resource implementation must use 2 different API versions to support creating both styles of AppInsights resource.

@dylanmorley
Copy link

Already reported here - Azure/azure-rest-api-specs#14801

@RickWinter RickWinter modified the milestones: Backlog, [2021] August Aug 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Monitor - ApplicationInsights Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests