Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azblob pager PageResponse() method returns an internal type #17823

Closed
jhendrixMSFT opened this issue May 5, 2022 · 1 comment · Fixed by #17867
Closed

azblob pager PageResponse() method returns an internal type #17823

jhendrixMSFT opened this issue May 5, 2022 · 1 comment · Fixed by #17867
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented May 5, 2022

// PageResponse returns the current containerClientListBlobFlatSegmentResponse page.
func (p *containerClientListBlobFlatSegmentPager) PageResponse() containerClientListBlobFlatSegmentResponse {
	return p.current
}

Public APIs should never return a type that's not exported.

In addition, the paging APIs need to be updated to return a *runtime.Pager[T], see example here.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 5, 2022
@jhendrixMSFT jhendrixMSFT added Storage Storage Service (Queues, Blobs, Files) blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels May 5, 2022
@mohsha-msft mohsha-msft linked a pull request May 17, 2022 that will close this issue
5 tasks
@jhendrixMSFT
Copy link
Member Author

Fixed in the refactor, will ship in [email protected]

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant