404 Not found when Downloading Blob w SAS client

[somtochiama]

Bug Report

• import path of package in question: "github.com/Azure/azure-sdk-for-go/sdk/storage/azblob"
• SDK version : v0.5.0
  • Specify the exact commit if possible; one way to get this is the REVISION
    column output by dep status "github.com/Azure/azure-sdk-for-go.
• output of go version
go version go1.19.1 darwin/amd64

• What happened?
  Downloading Blobs with a client created with a SAS query URL fails with a 404 (BlobNotFound) error
• What did you expect or want to happen?
  For it to succeeded. This isn't an authentication issue as the sas query has all permissions and attempting to download with one that doesn't returns an AuthenticationFailed error
• How can we reproduce it?

// create client with sas query: full path => <account>.blob.core.windows.net/<sasKey>
c, err = azblob.NewClientWithNoCredential(fullPath, &azblob.ClientOptions{})

// Listing the blobs work as expacted
items := c.NewListBlobsFlatPager(bucketName, nil)
for items.More() {
resp, err := items.NextPage(ctx)
if err != nil {
	err = fmt.Errorf("listing objects from bucket '%s' failed: %w", bucketName, err)
	return err
}
for _, blob := range resp.Segment.BlobItems {
	fmt.Println(*blob.Name)
}

// attempt to download w any of the Download functions returns 404 error
_, err = c.DownloadFile(ctx, bucketName, objectName, f, nil)
fmt.Println(err) // 404 Blob Not Found
if err != nil {
return "", err
}

Taking a look at the response error, there's a slash before the sas query which seems to be the cause of the problem. Path from (responeError.RawReqquest.Path )=> https://testfluxsaas.blob.core.windows.net/flux/notification.yml/?se=2022-10-11T04.. (extra slash after notification yaml).

Testing on Postman
GET https://testfluxsaas.blob.core.windows.net/flux/notification.yml?se=2022-10-11T04 (successful)
GET https://testfluxsaas.blob.core.windows.net/flux/notification.yml/?se=2022-10-11T04 (extra slash, BlobNotFound)

• Anything we should know about your environment.

[ghost]

Hi @somtochiama. Thank you for your feedback and we will look into it soon. Meanwhile, feel free to share your experience using the Azure SDK in this survey.

[somtochiama]

Digging further, the problem comes from the azcore/runtime function for JoinPath

if qps != "" {
if !strings.HasSuffix(root, "/") {
	root += "/"
}
return root + "?" + qps
}

It seems this is fixed in main?? Perhaps a new release then.

[jhendrixMSFT]

You should be able to update your dependency on azcore to v1.1.4 to resolve this. We'll also be releasing an updated [email protected] tomorrow (10/11/2022) that defaults to this version.

[jhendrixMSFT]

[email protected] is now available.