Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feq request] Cx would like to get the field in resp.X-Ms-Content-Crc64 from PUT blob API #23372

Closed
yangchengs opened this issue Aug 26, 2024 · 6 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team needs-team-triage Workflow: This issue needs the team to triage. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)

Comments

@yangchengs
Copy link

Feature Request

Cx wants to get the CRC64 content from response but it seems the current SDK does not handle it.

Pub blob rest API:
https://learn.microsoft.com/en-us/rest/api/storageservices/put-blob?tabs=microsoft-entra-id

image

But in the method func (client *BlockBlobClient) uploadHandleResponse(resp *http.Response) (BlockBlobClientUploadResponse, error),
it does not read the CRC64 content into the BlockBlobClientUploadResponse object.

https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/storage/azblob/internal/generated/zz_blockblob_client.go

image

https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/storage/azblob/blockblob/client.go
The UploadFileResponse returned from UploadFile method does not include CRC64 content.

Ask:
Add X-Ms-Content-Crc64 to UploadFileResponse

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files) labels Aug 26, 2024
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

@jhendrixMSFT jhendrixMSFT removed the Service Attention Workflow: This issue is responsible by Azure service team. label Aug 26, 2024
@github-actions github-actions bot added the needs-team-triage Workflow: This issue needs the team to triage. label Aug 26, 2024
@tanyasethi-msft
Copy link
Member

Hi, thanks for the request. I would like to clarify that to use PutBlob API in go-sdk, you have to use the following method -

func (bb *Client) Upload(ctx context.Context, body io.ReadSeekCloser, options *UploadOptions) (UploadResponse, error) {

We will add the crc header response to this API.

We cannot add checksums to UploadFile API since PutBlock is paralelly performed in this method and checksum cannot be supported here.

@yangchengs
Copy link
Author

@tanyasethi-msft Yes, confirmed with cx, this Upload method is what they want.

They also want to know if we can make the code change based on v.0.15.0

github.com/Azure/azure-storage-blob-go v0.15.0

@tanyasethi-msft
Copy link
Member

It cannot be made in v0.15.0 as that is already deprecated.

@tanyasethi-msft
Copy link
Member

The fix is merged in main and previewed. Will be GA'ed 3rd week of september

@tanyasethi-msft
Copy link
Member

This has been Ga'ed and is publicly available. Closing this thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team needs-team-triage Workflow: This issue needs the team to triage. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

5 participants
@jhendrixMSFT @yangchengs @tanyasethi-msft and others